Bug 1720608
| Summary: | Services dialog not getting created after import in service dialog accordion | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Red Hat CloudForms Management Engine | Reporter: | Niyaz Akhtar Ansari <nansari> | ||||
| Component: | Automate | Assignee: | drew uhlmann <duhlmann> | ||||
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Niyaz Akhtar Ansari <nansari> | ||||
| Severity: | high | Docs Contact: | Red Hat CloudForms Documentation <cloudforms-docs> | ||||
| Priority: | medium | ||||||
| Version: | 5.11.0 | CC: | bmidwood, duhlmann, gmccullo, hkataria, lavenel, mkanoor, mpovolny, mshriver, obarenbo, simaishi | ||||
| Target Milestone: | GA | ||||||
| Target Release: | 5.11.0 | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | 5.11.0.13 | Doc Type: | If docs needed, set a value | ||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2019-12-13 15:01:21 UTC | Type: | Bug | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | Bug | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | CFME Core | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Bug Depends On: | |||||||
| Bug Blocks: | 1696474 | ||||||
| Attachments: |
|
||||||
Hi Harpreet, The screenshot looks like they're trying to import the service dialog from the datastore import/export page. Is that correct? Thanks, Tina Dialog import appears to be broken. I tried to import 2 dialogs, one from the BZ and another one. It appeared from the UI that it worked but the dialogs don't appear in the explorer. Sprout Reproducer: 10.8.198.142 Version 5.11.0.8.20190611155126_01e077e I was successful importing dialogs from 5.11.0.6 and 5.11.0.8 appliances. Hope that helps Dialog import not working in Version 5.11.0.5.20190521144849_d0a06e6 Sprout Reproducer: 10.8.197.178 Working in Version 5.11.0.4.20190514210444_0c91ee1 Sprout Reproducer: 10.8.199.17 I think it's this: NoMethodError: undefined method `each' for false:FalseClass from /Users/duhlmann/manageiq/app/models/dialog_import_validator.rb:29:in `check_dialogs_for_validity' [----] F, [2019-06-19T15:28:38.135294 #79576:3fef04eaf1b8] FATAL -- : Error caught: [NoMethodError] undefined method `each' for false:FalseClass /Users/duhlmann/manageiq/app/models/dialog_import_validator.rb:29:in `check_dialogs_for_validity' /Users/duhlmann/manageiq/app/models/dialog_import_validator.rb:15:in `determine_validity' /Users/duhlmann/manageiq/lib/services/dialog_import_service.rb:68:in `store_for_import' /Users/duhlmann/.rvm/gems/ruby-2.5.1/bundler/gems/manageiq-ui-classic-74de2e89c4e3/app/controllers/miq_ae_customization_controller.rb:44:in `upload_import_file' /Users/duhlmann/.rvm/gems/ruby-2.5.1/gems/actionpack-5.0.7.2/lib/action_controller/metal/basic_implicit_render.rb:4:in `send_action' /Users/duhlmann/.rvm/gems/ruby-2.5.1/gems/actionpack-5.0.7.2/lib/abstract_controller/base.rb:188:in `process_action' /Users/duhlmann/.rvm/gems/ruby-2.5.1/gems/actionpack-5.0.7.2/lib/action_controller/metal/rendering.rb:30:in `process_action' /Users/duhlmann/.rvm/gems/ruby-2.5.1/gems/actionpack-5.0.7.2/lib/abstract_controller/callbacks.rb:20:in `block in process_action' /Users/duhlmann/.rvm/gems/ruby-2.5.1/gems/activesupport-5.0.7.2/lib/active_support/callbacks.rb:126:in `call' /Users/duhlmann/.rvm/gems/ruby-2.5.1/gems/activesupport-5.0.7.2/lib/active_support/callbacks.rb:506:in `block (2 levels) in compile' /Users/duhlmann/.rvm/gems/ruby-2.5.1/gems/activesupport-5.0.7.2/lib/active_support/callbacks.rb:455:in `call' /Users/duhlmann/.rvm/gems/ruby-2.5.1/gems/activesupport-5.0.7.2/lib/active_support/callbacks.rb:101:in `__run_callbacks__' Okay fine that's wrong, ignore 11 and 12 please visible: false as a setting in old dialogs is the reason this broke, looking into the change that caused this to stop working, but the create for ```def build_dialog_groups(dialog_tab, export_version = CURRENT_DIALOG_VERSION)``` in the main repo is failing because of ActiveRecord::RecordInvalid: Validation failed: DialogGroup: Dialog fields is invalid, Box Variables / DialogFieldCheckBox: Visible can't be blank |
Created attachment 1580642 [details] Affected Service dialog Description of problem: Version-Release number of selected component (if applicable): Version 5.11.0.8.20190611155126_01e077e How reproducible: 100% Steps to Reproduce: 1.Import the attached Service dialog Actual results: No Service Dialog import Expected results: It should import the dialog Additional info: