Bug 1721014
Summary: | 'rss' field is missing in dom->memory_stats() | ||
---|---|---|---|
Product: | Red Hat Enterprise Linux Advanced Virtualization | Reporter: | Dan Zheng <dzheng> |
Component: | perl-Sys-Virt | Assignee: | Daniel Berrangé <berrange> |
Status: | CLOSED ERRATA | QA Contact: | Dan Zheng <dzheng> |
Severity: | medium | Docs Contact: | |
Priority: | unspecified | ||
Version: | 8.1 | CC: | jdenemar, xuzhang |
Target Milestone: | rc | Keywords: | Automation, Regression |
Target Release: | 8.0 | ||
Hardware: | x86_64 | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | perl-Sys-Virt-5.6.0-1.module+el8.1.0+3895+267fb0f4 | Doc Type: | If docs needed, set a value |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2019-11-06 07:16:26 UTC | Type: | Bug |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
Dan Zheng
2019-06-17 07:03:12 UTC
I finally figured out whats wrong here. The memory stats API requires the caller to preallocate an array to hold stats. The array size is given by the VIR_DOMAIN_MEMORY_STAT_NR constant. In libvirt 5.4.0 a new memory stat was created, meaning VIR_DOMAIN_MEMORY_STAT_NR increased in size. The perl-Sys-Virt binding was still compiled against older libvirt 5.0.0, so the VIR_DOMAIN_MEMORY_STAT_NR value its passing is too small. This means the perl binding was missing 1 memory stat, which happened to be the 'rss' field since that is the last value to be added to the array. IOW, this will be fixed when we rebase. Package: perl-Sys-Virt-5.6.0-1.module+el8.1.0+3908+8a8c5ed4.x86_64 libvirt-5.6.0-2.module+el8.1.0+4015+63576633.x86_64 /var/tmp/libvirt-ci/runtest/libvirt-tck/libvirt-tck/scripts/domain/111-memory-stats.t .. 1..13 current perl-Sys-Virt version:5.6.0 ok 1 - created persistent domain object # Start domain ok 2 - running domain has an ID > 0 # Waiting 30 seconds for guest to finish booting # Set period on which guests memory stats are refreshed ok 3 - Set period to 10 # Get memory statistic when domain is active ok 4 - Get 'swap_in' is 0 ok 5 - Get 'swap_out' is 0 ... ok 13 - Get 'rss' is 551644 <=== Fixed Verified. Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHBA-2019:3723 |