Bug 172140
| Summary: | Review Request: libmal: a convenience library for malsync | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Rex Dieter <rdieter> |
| Component: | Package Review | Assignee: | John Mahowald <jpmahowald> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | David Lawrence <dkl> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | chabotc, fedora-extras-list, imlinux |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| URL: | http://jasonday.home.att.net/code/libmal/ | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2006-03-22 15:28:34 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 163779 | ||
|
Description
Rex Dieter
2005-10-31 19:20:12 UTC
*** Bug 172141 has been marked as a duplicate of this bug. *** Still looking for a reviewer? I'd be willing to pick it up. I see upstream has a new version (0.40), want to update it to that version or want the review to be for this one? Yes, still need a reviewer. No, I want/need libmal-0.31, since that's what kdepim currently can use. When/if there's ever a need/demand for 0.40, we can make a compat pkg. Looks good Do the patches included in this srpm have an upstream url that you could append to them in the spec file? The patches are from me, so there is no upstream url for them. Looks good overall, a few nitpicks: Needs work: * rpmlint of libmal: Remove empty files and capitalize summary. * The package should contain the text of the license (wiki: PackageReviewGuidelines) Just a couple spec tweaks, and query the author to package the license with the tarball. Oh, the license is included. Never mind about that. - rpmlint checks return: W: libmal summary-not-capitalized a convenience library for malsync W: libmal summary-not-capitalized a convenience library for malsync E: libmal zero-length /usr/share/doc/libmal-0.31/TODO E: libmal zero-length /usr/share/doc/libmal-0.31/NEWS E: libmal zero-length /usr/share/doc/libmal-0.31/AUTHORS W: libmal-debuginfo objdump-failed E: libmal-devel only-non-binary-in-usr-lib Capitalize summary and remove empty files. for devel package, only-non-binary-in-usr-lib, it's a symlink, ignore. - package meets naming guidelines - package meets packaging guidelines - license (MPL) OK, text in %doc, matches source - spec file legible, in am. english - source matches upstream - package compiles on devel (x86_64) - no missing BR - no unnecessary BR - no locales - not relocatable - owns all directories that it creates - no duplicate files - permissions ok - %clean ok - macro use consistent - code, not content - no need for -docs - nothing in %doc affects runtime - no need for .desktop file - devel package ok - no .la files - post/postun ldconfig ok - devel requires base package n-v-r APPROVED Thanks, imported, suggested minor changes incomporated into libmal-0.31-2 |