Bug 172183
| Summary: | Review Request: drgeo-doc | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Eric Tanguy <eric.tanguy> |
| Component: | Package Review | Assignee: | Aurelien Bompard <gauret> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | David Lawrence <dkl> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-extras-list |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2005-11-09 21:22:51 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 163779 | ||
|
Description
Eric Tanguy
2005-11-01 08:31:52 UTC
* Everything below %setup should be in %install. %prep is just for unpacking the archive and applying the patches. The install of the files should be in the %install section. * If you use "install -D" you don't need to use mkdir before * Use the -p switch of "install" to preserve timestamps * HTML files and pictures should be installed with mode 644, not 755. * Add the AUTHORS, README, TODO, ChangeLog, and COPYING files (In reply to comment #1) > * Everything below %setup should be in %install. %prep is just for unpacking the > archive and applying the patches. The install of the files should be in the > %install section. Ok > * If you use "install -D" you don't need to use mkdir before > * Use the -p switch of "install" to preserve timestamps > * HTML files and pictures should be installed with mode 644, not 755. Ok > * Add the AUTHORS, README, TODO, ChangeLog, and COPYING files Ok but without TODO which does not exist Spec Name or Url: http://perso.wanadoo.fr/eric.tanguy/drgeo-doc.spec SRPM Name or Url: http://perso.wanadoo.fr/eric.tanguy/drgeo-doc-1.6-2.src.rpm About the AUTHORS, README, ChangeLog, and COPYING files, it's better to package them as %doc in the %files section. What the rationale for not packaging these files as part of the drgeo rsp. drgeo-devel packages? To me, shipping them separately doesn't make much sense. (In reply to comment #4) > What the rationale for not packaging these files as part of the drgeo rsp. > drgeo-devel packages? > > To me, shipping them separately doesn't make much sense. It makes sense to package them separately because the soft and the doc does not move at the same rate. That's why the version number for the soft is 1.1.0 and 1.6 for doc. And that's why also the are shipped in 2 separate archives. New version : Spec Name or Url: http://perso.wanadoo.fr/eric.tanguy/drgeo-doc.spec SRPM Name or Url: http://perso.wanadoo.fr/eric.tanguy/drgeo-doc-1.6-3.src.rpm Also, a separate -doc rpm can be packaged as .noarch.rpm * The BuildRoot must be cleaned at the beginning of %install
* %{_datadir}/drgeo/help should be owned by the package, that was right.
* Don't copy the AUTHORS...COPYING files in %install, just put this in %files:
%doc AUTHORS README ChangeLog COPYING
It will copy the files to the right place (%_docdir) and tag them
Done. Spec Name or Url: http://perso.wanadoo.fr/eric.tanguy/drgeo-doc.spec SRPM Name or Url: http://perso.wanadoo.fr/eric.tanguy/drgeo-doc-1.6-4.src.rpm You have to own %{_datadir}/drgeo/help in this package, because it is not in
drgeo. Everything else looks OK.
Done : Spec Name or Url: http://perso.wanadoo.fr/eric.tanguy/drgeo-doc.spec SRPM Name or Url: http://perso.wanadoo.fr/eric.tanguy/drgeo-doc-1.6-5.src.rpm Review for release 5: * RPM name is OK * Source drgeo-doc-1.6.tar.gz is the same as upstream * Builds fine in mock * rpmlint of drgeo-doc looks OK * File list of drgeo-doc looks OK * Will be accessible from drgeo when bug 172321 is fixed APPROVED |