Bug 172343
| Summary: | Review Request: libtomoe-gtk (renamed tomoe-gtk) | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Ryo Dairiki <ryo-dairiki> |
| Component: | Package Review | Assignee: | John Mahowald <jpmahowald> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | David Lawrence <dkl> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | dchen, fedora-extras-list, petersen |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| URL: | http://tomoe.sourceforge.jp/ | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2006-03-21 22:55:00 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 163779, 178874 | ||
|
Description
Ryo Dairiki
2005-11-03 00:38:21 UTC
Build failed. checking for GTK2... configure: error: Package requirements (gtk+-2.0 >= 2.4.0) were not met: No package 'gtk+-2.0' found You will need BuildRequires: gtk2-devel Thank you for noticing me. I've fixed it. Now it must be okay. SRPM: http://proxy.f2.ymdb.yahoofs.jp/users/d1e4801f/bc/libtomoe-gtk/libtomoe-gtk-0.1.0-2.src.rpm?bcVMnIEB1KcJKSZg Spec: http://proxy.f2.ymdb.yahoofs.jp/users/d1e4801f/bc/libtomoe-gtk/libtomoe-gtk.spec?bcVMnIEBiSlAwHz9 Builds in mock now, FC4 i386. Needs work: * No downloadable source. Please give the full URL in the Source tag. * rpmlint of libtomoe-gtk-devel: Limit description lines to 80 characters. * Missing ldconfig scriptlet at %post and %postun. wiki: ScriptletSnippets Okay, now I've fixed them. SRPM: http://proxy.f2.ymdb.yahoofs.jp/users/d1e4801f/bc/libtomoe-gtk/libtomoe-gtk-0.1.0-3.src.rpm?bcoYzKEBlvI3Cvcz Spec: http://proxy.f2.ymdb.yahoofs.jp/users/d1e4801f/bc/libtomoe-gtk/libtomoe-gtk.spec?bcoYzKEBUlB0AzLT How annoying, the sourceforge link doesn't download automatically. md5sum checks manually though. Good: - rpmlint only notices that ldconfig in spec is a one line script. Can ignore, or use the -p option (wiki: ScriptletSnippets). - package meets naming guidelines - package meets packaging guidelines - license (GPL) OK, text in %doc, matches source - spec file legible, in am. english - source matches upstream - package compiles on FC4 i386 - no missing BR - no unnecessary BR - no locales - not relocatable - owns all directories that it creates - no duplicate files - permissions ok - %clean ok - macro use consistent - code, not content - no need for -docs - nothing in %doc affects runtime - no need for .desktop file - devel package ok - no .la files - devel requires base package n-v-r Missing ldconfig for the devel package, which I believe is needed. Looks good otherwise. Thank you for reviewing. I've fixed the following problems. 1. The sourcefiles is not downloaded automatically. 2. You must use "-p" int the "post" and "postun" sections. SRPM: http://proxy.f2.ymdb.yahoofs.jp/users/d1e4801f/bc/libtomoe-gtk/libtomoe-gtk-0.1.0-4.src.rpm?bcR5j2DBDHKQ6EjA SPEC: http://proxy.f2.ymdb.yahoofs.jp/users/d1e4801f/bc/libtomoe-gtk/libtomoe-gtk.spec?bcR5j2DBlYt9kUIe Links are not working. bcvrf.yahoo.com could not be found. I'm sorry, it seems like yahoo briefcase sometimes changes it's download link URLs. You can see them in libtomoe-gtk folder at http://briefcase.yahoo.co.jp/ryo_dairiki But I'll upload them as soon as I get a better file sharering repository. Now it's okay. I've uploaded them on the stable place. SRPM: http://homepage2.nifty.com/shibatama/garage/libtomoe-gtk-0.1.0-4.src.rpm SPEC: http://homepage2.nifty.com/shibatama/garage/libtomoe-gtk.spec # I'm sorry to have trouble you, with the old repository. New site downloads much better. One thing still blocking: the devel subpackage needs it's own call to ldconfig. See the ReviewGuidelines on the wiki. Good: - rpmlint checks return: W: libtomoe-gtk-debuginfo objdump-failed Not critical. - package meets naming guidelines - package meets packaging guidelines - license (GPL) OK, text in %doc, matches source - spec file legible, in am. english - source matches upstream - package compiles on devel (x86) - no missing BR - no unnecessary BR - locales handled by %find_lang - not relocatable - owns all directories that it creates - no duplicate files - permissions ok - %clean ok - macro use consistent - code, not content - no need for -docs - nothing in %doc affects runtime - no need for .desktop file - devel package ok - no .la files - devel requires base package n-v-r SPEC: http://homepage2.nifty.com/shibatama/garage/libtomoe-gtk.spec SRPM: http://homepage2.nifty.com/shibatama/garage/libtomoe-gtk-0.5. I've added ldconfig for the devel package. But I still get some errors and warnings, do you have any idea? rpmlint libtomot-gtk-devel: E: libtomoe-gtk-devel only-non-binary-in-usr-lib (Yeah, there is only "libtomoe-gtk.so" in that directory) rpmlint libtomoe-gtk-debuginfo: W: libtomoe-gtk-debuginfo objdump-failed (What is it?) Sorry, why does the -devel package need ldconfig? Initially I saw this guideline: - MUST: If the package contains shared library files located in the dynamic linker's default paths, that package must call ldconfig in %post and %postun. If the package has multiple subpackages with libraries, each subpackage should also have a %post/%postun section that calls /sbin/ldconfig. http://fedoraproject.org/wiki/Packaging/ReviewGuidelines and thought that there was a devel subpackage that has an object in the linker's path. However, on second thought, this is merely a symlink to the library in the main libtomoe-gtk package and so doesn't need it. What rpmlint has to say about objdump-failed: Executing objdump on this file failed, all checks could not be run. Which just means rpmlint couldn't examine the object files further. This is not serious. APPROVED Okay, thanks. Package in the repository. Please close bug when package builds successfully. Closing. Please add the package in owners.list > Please add the package in owners.list
Done, thanks.
Renaming this package to tomoe-gtk since that has been the upstream name for some time. |