Bug 1723472

Summary:	must-gather should redact kubectl.kubernetes.io/last-applied-configuration in secrets
Product:	OpenShift Container Platform	Reporter:	Naveen Malik <nmalik>
Component:	oc	Assignee:	Luis Sanchez <sanchezl>
Status:	CLOSED ERRATA	QA Contact:	zhou ying <yinzhou>
Severity:	high	Docs Contact:
Priority:	unspecified
Version:	4.2.0	CC:	aos-bugs, cblecker, gblomqui, jokerman, mmccomas, xxia
Target Milestone:	---
Target Release:	4.2.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:
Clones:	1735363 (view as bug list)		Environment:
Last Closed:	2019-10-16 06:32:20 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1735363

Description Naveen Malik 2019-06-24 15:09:24 UTC

Description of problem:
Some secret data is redacted but annotations are kept.  This means the encoded secret is gathered.

Version-Release number of selected component (if applicable):
oc version: v4.1.0+515979d-839-dirty
(note this is the version reported by oc binary from quay.io/openshift/origin-cli:4.2.0)

How reproducible:
Every time

Steps to Reproduce:
1. Get latest 4.2.0 cli from quay.io/openshift/origin-cli:4.2.0
2. Login to v4 cluster as kubeadmin
3. Run `oc adm must-gather`

Actual results:
Annotation "kubectl.kubernetes.io/last-applied-configuration" with passwords are not redacted.  

Expected results:
Annotation "kubectl.kubernetes.io/last-applied-configuration" with passwords are redacted along with the secret data.

Additional info:
Example of this is secret for LDAP bindPassword created in openshift-config namespace.  Both this secret and the copy of the secret in openshift-authentication have the encoded "bindPassword" value in annotation "kubectl.kubernetes.io/last-applied-configuration" in the must-gather output.

Comment 1 Luis Sanchez 2019-07-31 20:03:51 UTC

https://github.com/openshift/must-gather/pull/115

Comment 3 zhou ying 2019-08-01 07:10:55 UTC

Confirmed with image from Payload: 4.2.0-0.nightly-2019-08-01-035705, the issue has fixed:
Now all the secrets all empty like this:
  metadata:
    annotations:
      kubectl.kubernetes.io/last-applied-configuration: ""

Comment 4 errata-xmlrpc 2019-10-16 06:32:20 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2019:2922