Bug 1723486

Summary:	[RHOSP 14] iscsi.service on host should be disabled to avoid iscsid is started at host when some stale shutdown happens
Product:	Red Hat OpenStack	Reporter:	Pablo Caruana <pcaruana>
Component:	openstack-tripleo-heat-templates	Assignee:	Pablo Caruana <pcaruana>
Status:	CLOSED ERRATA	QA Contact:	Sasha Smolyak <ssmolyak>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	14.0 (Rocky)	CC:	aschultz, jschluet, knoha, mburns, pcaruana, rheslop, ssmolyak, tenobreg, tkajinam, tshefi
Target Milestone:	z4	Keywords:	TestOnly, Triaged, ZStream
Target Release:	14.0 (Rocky)
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	openstack-tripleo-heat-templates-9.3.1-0.20190513171739.el7ost	Doc Type:	Bug Fix
Doc Text:	This patch corrects a collision that occurs between the iscsid service and the iscsid container, causing the iscsid container to continuously restart. Now, the iscsid service on the host is disabled when deploying the iscsid container.	Story Points:	---
Clone Of:	1720561	Environment:
Last Closed:	2019-11-06 16:47:53 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1720561

Description Pablo Caruana 2019-06-24 15:58:21 UTC

+++ This bug was initially created as a clone of Bug #1720561 +++

Description of problem:

In RHOSP14, we run iscsid running inside container, and disable the one running on host.
However, when some stale shutdown happens, iscsi.service is started when booting that stale node,
and it launches iscsid.service on host.

This makes iscsid container stuck in "Restarting" with the following error.

~~~
Jun 14 17:11:12 compute-1 journal: INFO:__main__:Loading config file at /var/lib/kolla/config_files/config.json
Jun 14 17:11:12 compute-1 journal: INFO:__main__:Validating config file
Jun 14 17:11:12 compute-1 journal: INFO:__main__:Kolla config strategy set to: COPY_ALWAYS
Jun 14 17:11:12 compute-1 journal: INFO:__main__:Copying service configuration files
Jun 14 17:11:12 compute-1 journal: INFO:__main__:Deleting /etc/iscsi/iscsid.conf
Jun 14 17:11:12 compute-1 journal: INFO:__main__:Copying /var/lib/kolla/config_files/src-iscsid/iscsid.conf to /etc/iscsi/iscsid.conf
Jun 14 17:11:12 compute-1 journal: INFO:__main__:Deleting /etc/iscsi/initiatorname.iscsi
Jun 14 17:11:12 compute-1 journal: INFO:__main__:Copying /var/lib/kolla/config_files/src-iscsid/initiatorname.iscsi to /etc/iscsi/initiatorname.iscsi
Jun 14 17:11:12 compute-1 journal: INFO:__main__:Writing out command to execute
Jun 14 17:11:12 compute-1 journal: ++ cat /run_command
Jun 14 17:11:12 compute-1 journal: Running command: '/usr/sbin/iscsid -f'
Jun 14 17:11:12 compute-1 journal: + CMD='/usr/sbin/iscsid -f'
Jun 14 17:11:12 compute-1 journal: + ARGS=
Jun 14 17:11:12 compute-1 journal: + [[ ! -n '' ]]
Jun 14 17:11:12 compute-1 journal: + . kolla_extend_start
Jun 14 17:11:12 compute-1 journal: ++ [[ ! -f /etc/iscsi/initiatorname.iscsi ]]
Jun 14 17:11:12 compute-1 journal: + echo 'Running command: '\''/usr/sbin/iscsid -f'\'''
Jun 14 17:11:12 compute-1 journal: + exec /usr/sbin/iscsid -f
Jun 14 17:11:12 compute-1 journal: iscsid: Can not bind IPC socket
~~~

Version-Release number of selected component (if applicable):
z3

How reproducible:

Always

Steps to Reproduce:
1. Create an instance, with iscsi cinder volume attached
2. Force reboot the node where the instance is running

Actual results:
iscsi.service launches iscsid.service on host, and iscsid container get stuck in Restarting

Expected results:
iscsid.service on host is not started, and iscsid container get started without any error


Additional info:

We see this issue since we made iscsi session shared by host and container,
to solve shutdown problem of compute nodes.[1]

[1] https://bugzilla.redhat.com/show_bug.cgi?id=1655815

Comment 1 Lon Hohberger 2019-09-04 10:44:18 UTC

According to our records, this should be resolved by openstack-tripleo-heat-templates-9.3.1-0.20190513171752.el7ost.  This build is available now.

Comment 5 Tzach Shefi 2019-09-26 00:46:51 UTC

Still waiting for a newer build than 14  -p 2019-09-06.1

Comment 6 Tzach Shefi 2019-10-02 04:37:34 UTC

Still don't see a newer than 2019-09-06.1

Comment 10 errata-xmlrpc 2019-11-06 16:47:53 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2019:3745