Bug 1724204

Summary:	[IPI] [OSP] oc get machines do not show infomation about openstack instances
Product:	OpenShift Container Platform	Reporter:	David Sanz <dsanzmor>
Component:	Installer	Assignee:	Mike Fedosin <mfedosin>
Installer sub component:	openshift-installer	QA Contact:	David Sanz <dsanzmor>
Status:	CLOSED ERRATA	Docs Contact:
Severity:	low
Priority:	low	CC:	jhou, ltomasbo, mfedosin, ppitonak
Version:	4.2.0	Keywords:	Triaged
Target Milestone:	---
Target Release:	4.2.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2019-10-16 06:32:41 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description David Sanz 2019-06-26 13:14:29 UTC

Description of problem:
When executing oc get machines -n openshift-machine-api on IPI-on-AWS, we can see information about the EC2 instances deployed:

$ oc get machines -n openshift-machine-api
NAME                                        INSTANCE              STATE     TYPE        REGION      ZONE         AGE
morenod-ocp-2z7t4-master-0                  i-07353ad60be7f6a76   running   m4.xlarge   us-west-1   us-west-1a   23h
morenod-ocp-2z7t4-master-1                  i-0355b6293a14e7210   running   m4.xlarge   us-west-1   us-west-1c   23h
morenod-ocp-2z7t4-master-2                  i-02f16eefa633bda59   running   m4.xlarge   us-west-1   us-west-1a   23h
morenod-ocp-2z7t4-worker-us-west-1a-hzbls   i-0332a50c9d8a116a5   running   m4.large    us-west-1   us-west-1a   23h
morenod-ocp-2z7t4-worker-us-west-1a-th72f   i-058442465d57a26d7   running   m4.large    us-west-1   us-west-1a   23h
morenod-ocp-2z7t4-worker-us-west-1c-p9m84   i-02609f43b4b55ff47   running   m4.large    us-west-1   us-west-1c   23h


If we execute same command on IPI-on-OSP, there is no information about the openstack instances.

$ oc get machines -n openshift-machine-api
NAME                             INSTANCE   STATE   TYPE   REGION   ZONE   AGE
morenod-ocp-c9xgq-master-0                                                 52m
morenod-ocp-c9xgq-master-1                                                 52m
morenod-ocp-c9xgq-master-2                                                 52m
morenod-ocp-c9xgq-worker-42gt2                                             4m16s
morenod-ocp-c9xgq-worker-5f7vh                                             51m
morenod-ocp-c9xgq-worker-jjwcw                                             51m
morenod-ocp-c9xgq-worker-rsnz8                                             4m16s
morenod-ocp-c9xgq-worker-v2j9f                                             51m


Version-Release number of the following components:
$ ./openshift-install version
./openshift-install v4.2.0-201906252232-dirty
built from commit 26c5e504fc48e8426750e3d3e4f46aa9b91b01e6
release image registry.svc.ci.openshift.org/ocp/release@sha256:090257e40570d8ec2a37844634ec1e985ad60d094fda7c3216261735ffd3c9f4


How reproducible:

Steps to Reproduce:
1.Install openshift using IPI-on-OSP
2.Execute `oc get machineset -n openshift-machine-api`

Actual results:
Please include the entire output from the last TASK line through the end of output if an error is generated

Expected results:

Additional info:
Please attach logs from ansible-playbook with the -vvv flag

Comment 1 Mike Fedosin 2019-07-19 16:31:37 UTC

Well, looks like these values are hardcoded to AWS in the machine crd:
https://github.com/openshift/machine-api-operator/blob/master/install/0000_30_machine-api-operator_02_machine.crd.yaml#L9-L33
It means that the information about machines is returned from the server, but just not printed in the console because the values are called differently.
As a solution I think we can introduce some kind of templating for the crd and set additionalPrinterColumns depending on the underlying platform (AWS, OpenStack, Azure, etc)

Comment 2 Mike Fedosin 2019-07-25 14:41:35 UTC

Here's a related task in Jira https://jira.coreos.com/browse/CLOUD-453
Since all platforms are affected, they plan to create platform-agnostic keys in the machine metadata and define them in cluster api providers. The patch for Azure is already done. I'm preparing a patch for OpenStack

Comment 3 Eric Duen 2019-07-30 15:43:37 UTC

Assigning to Mike.

Comment 4 Jan Chaloupka 2019-08-19 10:54:14 UTC

*** Bug 1741839 has been marked as a duplicate of this bug. ***

Comment 6 David Sanz 2019-08-21 10:37:34 UTC

Verified on: 4.2.0-0.nightly-2019-08-21-040043

Nodes:

NAME                             STATUS   ROLES    AGE     VERSION
morenod-ocp-hk2bb-master-0       Ready    master   39m     v1.14.0+17b784327
morenod-ocp-hk2bb-master-1       Ready    master   39m     v1.14.0+17b784327
morenod-ocp-hk2bb-master-2       Ready    master   39m     v1.14.0+17b784327
morenod-ocp-hk2bb-worker-8vsrp   Ready    worker   8m20s   v1.14.0+17b784327

Machines:

NAME                             STATE    TYPE           REGION      ZONE   AGE
morenod-ocp-hk2bb-master-0       ACTIVE   ci.m1.xlarge   regionOne   nova   39m
morenod-ocp-hk2bb-master-1	 ACTIVE   ci.m1.xlarge   regionOne   nova   39m
morenod-ocp-hk2bb-master-2	 ACTIVE   ci.m1.xlarge   regionOne   nova   39m
morenod-ocp-hk2bb-worker-8vsrp   ACTIVE   ci.m1.xlarge   regionOne   nova   38m

Comment 7 errata-xmlrpc 2019-10-16 06:32:41 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2019:2922