Bug 172428

Summary:	Review Request: acpitool - A command line ACPI client for Linux
Product:	[Fedora] Fedora	Reporter:	Patrice Dumas <pertusus>
Component:	Package Review	Assignee:	John Mahowald <jpmahowald>
Status:	CLOSED NEXTRELEASE	QA Contact:	Fedora Package Reviews List <fedora-package-review>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
URL:	http://freeunix.dyndns.org:8088/site2/acpitool.shtml
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2005-11-11 20:40:30 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	163779

Description Patrice Dumas 2005-11-04 10:37:16 UTC

SRPM Name or Url: fttp://www.environnement.ens.fr/perso/dumas/fc-srpms/acpitool-0.3.0-2.src.rpm

Description: 

AcpiTool is a Linux ACPI client. It's a small command line application,
intended to be a replacement for the apm tool. The primary target
audience are laptop users, since these people are most interested in
things like battery status, thermal status and the ability to suspend
(sleep mode). The program simply accesses the /proc/acpi or /sysfs entries
to get/set acpi values. Hence, a computer running a Linux kernel from
the 2.4.x or 2.6.x series with ACPI enabled is needed.

Comment 1 Patrice Dumas 2005-11-05 23:30:50 UTC

The correct url is in fact:

http://www.environnement.ens.fr/perso/dumas/fc-srpms/acpitool-0.3.0-2.src.rpm

Comment 2 John Mahowald 2005-11-10 17:18:23 UTC

`-mcpu=' is deprecated. Use `-mtune=' or '-march=' instead.

Specify CXXFLAGS to configure, like %configure CXXFLAGS=%{_optflags}

Good:
- package meets naming guidelines
- package meets packaging guidelines
- license (GPL) OK, text in %doc, matches source
- spec file legible, in am. english
- source matches upstream
- package compiles on FC4 i386
- no missing BR
- no unnecessary BR
- no locales
- not relocatable
- owns all directories that it creates
- no duplicate files
- permissions ok
- %clean ok
- macro use consistent
- code, not content
- no need for -docs
- nothing in %doc affects runtime
- no need for .desktop file

Have not tested yet.

Comment 3 Patrice Dumas 2005-11-10 23:39:10 UTC

%configure allready defines CXXFLAGS to the right value; the issue is in the
upstream configure.in script where compiler flags are setting although they
shouldn't. I have patched the configure script, now it uses the optflags. See
the srpm here:

http://www.environnement.ens.fr/perso/dumas/fc-srpms/acpitool-0.3.0-3.src.rpm

I also have contacted the upstream.

Comment 4 John Mahowald 2005-11-11 02:26:04 UTC

Clean build now. APPROVED

Comment 5 Christian Iseli 2006-10-18 12:50:59 UTC

Normalize summary field for easy parsing