Bug 1724485

Summary: clustershell FTBFS in rawhide
Product: [Fedora] Fedora Reporter: Lumír Balhar <lbalhar>
Component: clustershellAssignee: Stephane Thiell <sthiell>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 31CC: sthiell
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: clustershell-1.8.3-1.fc31 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2019-12-16 01:19:18 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Lumír Balhar 2019-06-27 07:46:23 UTC
clustershell fails to build from source in Fedora rawhide because there are a few "%else if" statements in the specfile - they should be changed to "%elif".

BUILDSTDERR: warning: extra tokens at the end of %else directive in line 37:  %else if 0%{?rhel}
BUILDSTDERR: warning: extra tokens at the end of %else directive in line 37:  %else if 0%{?rhel}
BUILDSTDERR: warning: extra tokens at the end of %else directive in line 45:  %else if 0%{?suse_version}
BUILDSTDERR: error: /builddir/build/SPECS/clustershell.spec: line 48: %else after %else

https://src.fedoraproject.org/rpms/clustershell/blob/master/f/clustershell.spec#_45

Comment 1 Stephane Thiell 2019-06-27 10:48:13 UTC
Thanks Lumír for reporting this.

Can't really use %elif neither as it is not well supported. I think this is a relatively new feature.

Example of error I get on EL7:

error: line 47: Unknown tag: %elif

So the thing is that the first %else if statement can actually be completely removed because it was only used for the obsolete Group tag that was removed in last January.

The other one, I replaced it with simple %else / %if statements. It's the most portable right now I guess.

https://src.fedoraproject.org/rpms/clustershell/c/96e6a1373d725a2bf9c03949aa72c43bd47833ea?branch=master

Comment 2 Ben Cotton 2019-08-13 16:56:01 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 31 development cycle.
Changing version to '31'.

Comment 3 Ben Cotton 2019-08-13 19:08:37 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 31 development cycle.
Changing version to 31.

Comment 4 Fedora Update System 2019-12-07 21:55:00 UTC
FEDORA-2019-b1ea7233af has been submitted as an update to Fedora 31. https://bodhi.fedoraproject.org/updates/FEDORA-2019-b1ea7233af

Comment 5 Fedora Update System 2019-12-08 01:46:53 UTC
clustershell-1.8.3-1.fc31 has been pushed to the Fedora 31 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-b1ea7233af

Comment 6 Fedora Update System 2019-12-16 01:19:18 UTC
clustershell-1.8.3-1.fc31 has been pushed to the Fedora 31 stable repository. If problems still persist, please make note of it in this bug report.