Bug 172476

Summary: netpoll: avoid kfree_skb on packets with destructors
Product: Red Hat Enterprise Linux 4 Reporter: Jeff Moyer <jmoyer>
Component: kernelAssignee: Neil Horman <nhorman>
Status: CLOSED ERRATA QA Contact: Brian Brock <bbrock>
Severity: medium Docs Contact:
Priority: medium    
Version: 4.0CC: jbaron, lwang, tgraf
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: RHBA-2007-0304 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2007-05-01 23:57:20 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
don't call __kfree_skb on skb's with destructors none

Description Jeff Moyer 2005-11-04 23:07:53 UTC 
Description of problem:

Netpoll will generate an unwanted printk when __kfree_skb is called with a
destructor from interrupt context.  Here is a discussion of the patch:
  http://oss.sgi.com/projects/netdev/archive/2005-03/msg00161.html

The version for RHEL will also have a conditional based upon whether or not we
are in netdump_mode.  If in netdump_mode, always do __kfree_skb, as we otherwise
have no way of freeing the skb.

Version-Release number of selected component (if applicable):
kernel-2.6.9-22

How reproducible:


Steps to Reproduce:
1.
2.
3.
  
Actual results:


Expected results:


Additional info:
Comment 1 Jeff Moyer 2005-11-04 23:07:53 UTC 
Created attachment 120746 [details]
don't call __kfree_skb on skb's with destructors
Comment 2 Neil Horman 2006-12-06 13:57:28 UTC 
built, verified and posted.  Thanks!
Comment 3 Jason Baron 2007-01-05 16:27:23 UTC 
committed in stream U5 build 42.38. A test kernel with this patch is available
from http://people.redhat.com/~jbaron/rhel4/
Comment 4 RHEL Program Management 2007-01-18 16:27:47 UTC 
This request was evaluated by Red Hat Product Management for inclusion in a Red
Hat Enterprise Linux maintenance release.  Product Management has requested
further review of this request by Red Hat Engineering, for potential
inclusion in a Red Hat Enterprise Linux Update release for currently deployed
products.  This request is not yet committed for inclusion in an Update
release.
Comment 5 Jay Turner 2007-01-18 20:46:49 UTC 
QE ack for RHEL4.5.
Comment 8 Red Hat Bugzilla 2007-05-01 23:57:20 UTC 
An advisory has been issued which should help the problem
described in this bug report. This report is therefore being
closed with a resolution of ERRATA. For more information
on the solution and/or where to find the updated files,
please follow the link below. You may reopen this bug report
if the solution does not work for you.

http://rhn.redhat.com/errata/RHBA-2007-0304.html