Bug 1726069

Summary:	multus pods as infra component should not keep experimental "critical-pod" annotation
Product:	OpenShift Container Platform	Reporter:	Xingxing Xia <xxia>
Component:	Networking	Assignee:	Casey Callendrello <cdc>
Networking sub component:	openshift-sdn	QA Contact:	zhaozhanqi <zzhao>
Status:	CLOSED ERRATA	Docs Contact:
Severity:	medium
Priority:	medium	CC:	aos-bugs, cdc
Version:	4.1.0
Target Milestone:	---
Target Release:	4.2.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	No Doc Update
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2019-10-16 06:32:48 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Xingxing Xia 2019-07-02 07:27:13 UTC

Description of problem:
multus pods as infra component should not keep experimental "critical-pod" annotation

Version-Release number of selected component (if applicable):
4.1.4

How reproducible:
Always

Steps to Reproduce:
1. Launch 4.1 env
2. oc get po --all-namespaces -o yaml > pods.yaml
3. Check "critical-pod" word in pods.yaml

Actual results:
3. Found only multus pods in openshift-multus project still keep experimental "scheduler.alpha.kubernetes.io/critical-pod" annotation, though they already use 
.spec.priorityClassName

Expected results:
3. Now that they already use .spec.priorityClassName, they should not keep experimental "critical-pod" annotation

Additional info:
multus pods are infra component:
$ oc get po -n openshift-multus --show-labels
NAME           READY   STATUS    RESTARTS   AGE   LABELS
multus-9dqwr   1/1     Running   0          25h   ...component=network,...openshift.io/component=network,...type=infra

Comment 1 Casey Callendrello 2019-07-15 20:10:53 UTC

Alex has fixed this, I believe. Alex, can you post the PR number and move the status to "MODIFIED"? That let's QE know they can verify it.

Comment 2 Alexander Constantinescu 2019-07-16 08:20:59 UTC

Hi

Yes, this has been fixed with PR 226 (https://github.com/openshift/cluster-network-operator/pull/226). 

Sorry for the delay in updating this ticket.

Best, 
Alex

Comment 4 Xingxing Xia 2019-07-17 05:55:09 UTC

Verified in 4.2.0-0.nightly-2019-07-16-173254.

Comment 5 errata-xmlrpc 2019-10-16 06:32:48 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2019:2922