Bug 1726419

Summary: xorg-x11-server-Xorg update to 1.20.5 causes screen tearing
Product: [Fedora] Fedora Reporter: André <hu3breopoder>
Component: xorg-x11-serverAssignee: X/OpenGL Maintenance List <xgl-maint>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 30CC: bskeggs, caillon+fedoraproject, fedora, jglisse, john.j5live, ofbugsandmen, ofourdan, rhughes, robin.a.meade, rstrode, sandmann, ubizjak, xgl-maint
Target Milestone: ---   
Target Release: ---   
Hardware: x86_64   
OS: Linux   
Whiteboard:
Fixed In Version: xorg-x11-server-1.20.5-4.fc30 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Version with tearing: 1.20.5-3.fc30 (updates) Version without tearing: 1.20.4-3.fc30 (fedora)
Last Closed: 2019-07-12 00:58:54 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
How the panel looks like when the bug is triggered none

Description André 2019-07-02 19:42:20 UTC
Description of problem:

The newest xorg update version 1.20.5 has screen tearing on some systems. In my case it's a  HD 620 (problem happens with both kernel/nomodeset and xorg's xf86 intel drivers).  Had to downgrade to 1.20.4-3.fc30 from fedora repository.

Upstream bug report: https://gitlab.freedesktop.org/xorg/xserver/issues/839

Arch users talking about this issue: https://www.reddit.com/r/archlinux/comments/bxsfy4/xorgserver12051_is_broken/

Comment 1 Paweł Brodacki 2019-07-03 04:30:27 UTC
I'm affected by this bug too.

Problem solved by
dnf downgrade xorg-x11-server-Xorg-1.20.4-3.fc30 xorg-x11-server-common-1.20.4-3.fc30.x86_64

In my case:
o) The graphics hardware is Radeon HD 5870.
o) The bug affects only KDE panel.
o) The bug can be reproduced on xorg-x11-server-Xorg-1.20.4-3 as well by running and quitting Wesnoth.

Comment 2 Paweł Brodacki 2019-07-03 04:40:15 UTC
Created attachment 1586913 [details]
How the panel looks like when the bug is triggered

Comment 3 Olivier Fourdan 2019-07-03 07:13:52 UTC
(In reply to Paweł Brodacki from comment #1)
> I'm affected by this bug too.
 
The picture in attachment 1586913 [details] is not tearing, this corruption, I doubt this is the same issue.

> Problem solved by
> dnf downgrade xorg-x11-server-Xorg-1.20.4-3.fc30
> xorg-x11-server-common-1.20.4-3.fc30.x86_64

What exact version (n-v-r) of the Fedora package for xorg-x11-server-Xorg are you using?
 
> In my case:
> o) The graphics hardware is Radeon HD 5870.
> o) The bug affects only KDE panel.
> o) The bug can be reproduced on xorg-x11-server-Xorg-1.20.4-3 as well by
> running and quitting Wesnoth.

So you can reproduce with xorg-x11-server-Xorg-1.20.4-3 as well? That's not a regression in 1.20.5 then.

This is confusing because you mentioned “Problem solved by dnf downgrade xorg-x11-server-Xorg-1.20.4-3.fc30” and then “The bug can be reproduced on xorg-x11-server-Xorg-1.20.4-3 as well”, you lost me there...

I would suggest to:

1. File a different bug, your screen-shot does not show tearing but plain corruption
2. Try to reproduce with different versions of the Xserver (dnf downgrade) and if possible identify the first exact package version which introduced the issue (we do add patches downstream, so every release counts)
3. Make sure to mention the exact version of the package affected.

Comment 4 Olivier Fourdan 2019-07-03 07:16:39 UTC
(In reply to André from comment #0)
> Description of problem:
> 
> The newest xorg update version 1.20.5 has screen tearing on some systems.

Please provide the exact package version, “newest” tends to be unclear over time.

> my case it's a  HD 620 (problem happens with both kernel/nomodeset and
> xorg's xf86 intel drivers).  Had to downgrade to 1.20.4-3.fc30 from fedora
> repository.
> 
> Upstream bug report: https://gitlab.freedesktop.org/xorg/xserver/issues/839
> 
> Arch users talking about this issue:
> https://www.reddit.com/r/archlinux/comments/bxsfy4/xorgserver12051_is_broken/

Every distribution can add patches to their packages, I'd rather focus on Fedora, considering this is a Fedora bugzilla.

Comment 5 André 2019-07-03 09:45:51 UTC
Version with tearing: 1.20.5-3.fc30 (updates)
Version without tearing: 1.20.4-3.fc30 (fedora)

Comment 6 Olivier Fourdan 2019-07-03 10:06:29 UTC
(In reply to André from comment #5)
> Version with tearing: 1.20.5-3.fc30 (updates)
> Version without tearing: 1.20.4-3.fc30 (fedora)

Could you please try this scratch (test) build so see if it helps with the issue?

https://koji.fedoraproject.org/koji/taskinfo?taskID=36015101

Comment 7 André 2019-07-03 16:41:48 UTC
(In reply to Olivier Fourdan from comment #6)
> (In reply to André from comment #5)
> > Version with tearing: 1.20.5-3.fc30 (updates)
> > Version without tearing: 1.20.4-3.fc30 (fedora)
> 
> Could you please try this scratch (test) build so see if it helps with the
> issue?
> 
> https://koji.fedoraproject.org/koji/taskinfo?taskID=36015101

I've downloaded and installed all .rpms for x86_64 and rebooted the computer. Didn't fix it at all (still have tearing).

Comment 8 Uros Bizjak 2019-07-04 06:19:48 UTC
(In reply to Paweł Brodacki from comment #2)
> Created attachment 1586913 [details]
> How the panel looks like when the bug is triggered

Following bugreport shows the same corruption with KDE tooltips:

https://bugzilla.redhat.com/show_bug.cgi?id=1725499

Comment 9 Olivier Fourdan 2019-07-04 06:48:22 UTC
(In reply to André from comment #7)
> (In reply to Olivier Fourdan from comment #6)
> > Could you please try this scratch (test) build so see if it helps with the
> > issue?
> > 
> > https://koji.fedoraproject.org/koji/taskinfo?taskID=36015101
> 
> I've downloaded and installed all .rpms for x86_64 and rebooted the
> computer. Didn't fix it at all (still have tearing).

Thanks, that's a relief! So I think this really is an upstream issue.

I've reverted the patch Michel pointed out upstream and ran a new scratch build:

https://koji.fedoraproject.org/koji/taskinfo?taskID=36027647

Can you try this new one?

Comment 10 André 2019-07-04 09:24:51 UTC
(In reply to Olivier Fourdan from comment #9)
> (In reply to André from comment #7)
> > (In reply to Olivier Fourdan from comment #6)
> > > Could you please try this scratch (test) build so see if it helps with the
> > > issue?
> > > 
> > > https://koji.fedoraproject.org/koji/taskinfo?taskID=36015101
> > 
> > I've downloaded and installed all .rpms for x86_64 and rebooted the
> > computer. Didn't fix it at all (still have tearing).
> 
> Thanks, that's a relief! So I think this really is an upstream issue.
> 
> I've reverted the patch Michel pointed out upstream and ran a new scratch
> build:
> 
> https://koji.fedoraproject.org/koji/taskinfo?taskID=36027647
> 
> Can you try this new one?

It works! No tearing using this one. Thank you.

Comment 11 Olivier Fourdan 2019-07-04 09:34:12 UTC
(In reply to André from comment #10)
> It works! No tearing using this one. Thank you.

Thanks for testing! Now awaiting the feedback from bug 1725499 as well, and I'll push that in Fedora.

Comment 12 Fedora Update System 2019-07-08 09:26:49 UTC
FEDORA-2019-645cab930b has been submitted as an update to Fedora 30. https://bodhi.fedoraproject.org/updates/FEDORA-2019-645cab930b

Comment 13 Fedora Update System 2019-07-09 01:21:59 UTC
xorg-x11-server-1.20.5-4.fc30 has been pushed to the Fedora 30 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-645cab930b

Comment 14 Fedora Update System 2019-07-12 00:58:54 UTC
xorg-x11-server-1.20.5-4.fc30 has been pushed to the Fedora 30 stable repository. If problems still persist, please make note of it in this bug report.