Bug 1726568

Reviewed v10 of the patchset, and waiting for a v11 to come out and if all is fine will ack the patchset.

Reviewed the v12 patch, and sent comment upstream to dev mailing list

v13 is out but I had some comments. Waiting for feedback or a v14 for six weeks now. I asked for an update 2 weeks ago, but no response, sent a gentle reminder today.

v14 was sent out, tested and reviewed it. Waiting for inclusion in master branch so we include it in our OVS distribution

Reviewed v15, one small comment:

https://mail.openvswitch.org/pipermail/ovs-dev/2019-November/364563.html

Backported to 2.11 and 2.12:

http://download.eng.bos.redhat.com/brewroot/vol/rhel-7/packages/openvswitch2.11/2.11.0/42.el7fdn/
http://download.eng.bos.redhat.com/brewroot/vol/rhel-7/packages/openvswitch2.12/2.12.0/20.el7fdn/

Hi Eelco,

Can you provide further details on how to set up and test this new functionality?  Based on what I've reviewed, I assume there will be additional statistics being reported via ovs-appctl but I'm unsure what specific commands should be executed or statistics to check for and I'm unsure how to generate the necessary statistics to verify the feature.

Please advise.

Thanks,
Rick

Hi Rick,

Yes all the potential reasons for dropping a packet now have a coverage counter. To be more specific the following new counters are defined:

$ grep COVERAGE_DEFINE 0001-userspace-Improved-packet-drop-statistics.patch
+COVERAGE_DEFINE(datapath_drop_meter);
+COVERAGE_DEFINE(datapath_drop_upcall_error);
+COVERAGE_DEFINE(datapath_drop_lock_error);
+COVERAGE_DEFINE(datapath_drop_userspace_action_error);
+COVERAGE_DEFINE(datapath_drop_tunnel_push_error);
+COVERAGE_DEFINE(datapath_drop_tunnel_pop_error);
+COVERAGE_DEFINE(datapath_drop_recirc_error);
+COVERAGE_DEFINE(datapath_drop_invalid_port);
+COVERAGE_DEFINE(datapath_drop_invalid_tnl_port);
+COVERAGE_DEFINE(datapath_drop_rx_invalid_packet);
+COVERAGE_DEFINE(datapath_drop_sample_error);
+COVERAGE_DEFINE(datapath_drop_nsh_decap_error);
+COVERAGE_DEFINE(drop_action_of_pipeline);
+COVERAGE_DEFINE(drop_action_bridge_not_found);
+COVERAGE_DEFINE(drop_action_recursion_too_deep);
+COVERAGE_DEFINE(drop_action_too_many_resubmit);
+COVERAGE_DEFINE(drop_action_stack_too_deep);
+COVERAGE_DEFINE(drop_action_no_recirculation_context);
+COVERAGE_DEFINE(drop_action_recirculation_conflict);
+COVERAGE_DEFINE(drop_action_too_many_mpls_labels);
+COVERAGE_DEFINE(drop_action_invalid_tunnel_metadata);
+COVERAGE_DEFINE(drop_action_unsupported_packet_type);
+COVERAGE_DEFINE(drop_action_congestion);
+COVERAGE_DEFINE(drop_action_forwarding_disabled);

These counters will show up in the "ovs-appctl coverage/show" if they have occurred at least once. It's hard to create a test that would trigger all. I would suggest trying to trigger one or two for confirmation of the patch inclusion. 

Some of the tests are also in the autotest you could use them:

https://github.com/openvswitch/ovs/blob/master/tests/drop-stats.at

In addition some more tests where part of the original patch (check the *.at files).

https://patchwork.ozlabs.org/patch/1136660/

Hi Eelco,

Based on comment #6, this feature appears to be for both openvswitch2.11 and openvswitch2.12.  Is there a separate BZ tracking its inclusion on openvswitch2.12?  Is this feature for both RHEL-7 and RHEL-8?

Please advise so I can verify in the appropriate builds.

Thanks,
Rick

Yes,
see the cloned bugzilla bz#1796571

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2020:0743