Bug 1727811

Summary:	WARNING Changing machine type from '%s' to 'q35' which is required for UEFI secure boot
Product:	Red Hat Enterprise Linux 8	Reporter:	zhoujunqin <juzhou>
Component:	virt-manager	Assignee:	Pavel Hrdina <phrdina>
Status:	CLOSED ERRATA	QA Contact:	Virtualization Bugs <virt-bugs>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	8.1	CC:	mxie, phrdina, tzheng, xiaodwan, zili
Target Milestone:	rc
Target Release:	8.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	virt-manager-2.2.1-1.el8	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2019-11-05 21:20:21 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description zhoujunqin 2019-07-08 08:51:16 UTC

Description of problem:
virt-install uses "%s" directly in its warning message:
WARNING  Changing machine type from '%s' to 'q35' which is required for UEFI secure boot.

Version-Release number of selected component (if applicable):
virt-install-2.2.0-2.el8.noarch
virt-manager-common-2.2.0-2.el8.noarch

How reproducible:
100%

Steps to Reproduce:
1. Install a UEFI vm
# virt-install --name test --memory 1024 --disk /var/lib/libvirt/images/test.img,size=1 --import --boot uefi --noreboot
WARNING  Changing machine type from '%s' to 'q35' which is required for UEFI secure boot.
WARNING  No operating system detected, VM performance may suffer. Specify an OS with --os-variant for optimal results.
...

Actual results:
As subject.

Expected results:
Fix it.

Additional info:
It was introduced recently by this commit 3586d1897.

Comment 1 Pavel Hrdina 2019-07-08 13:00:59 UTC

Upstream commit:

commit 3c6e85375d0cd87dcf8ac70b41db0d899851338e
Author: Pavel Hrdina <phrdina>
Date:   Mon Jul 8 10:44:43 2019 +0200

    guest: fix warning message when machine type is changed for secure boot

Comment 4 zhoujunqin 2019-07-15 06:19:23 UTC

Then try to verify this bug with new build:
virt-manager-2.2.1-1.el8.noarch
virt-install-2.2.1-1.el8.noarch
libvirt-4.5.0-24.module+el8.1.0+3205+41ff0a42.x86_64
qemu-kvm-2.12.0-77.module+el8.1.0+3382+49219945.x86_64
python3-libvirt-4.5.0-1.module+el8+2529+a9686a4d.x86_64

Steps:
1. Install a UEFI vm

# virt-install --name test --memory 1024 --disk /var/lib/libvirt/images/test.img,size=1 --import --boot uefi --noreboot
WARNING  Changing machine type from 'pc-i440fx-rhel7.6.0' to 'q35' which is required for UEFI secure boot.
...

Result: Warning message is correct when machine type is changed for secure boot, so I move this bug from ON_QA to VERIFIED.

Comment 6 errata-xmlrpc 2019-11-05 21:20:21 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2019:3464