Bug 172870

Summary: Review Request: fdupes
Product: [Fedora] Fedora Reporter: Bastien Nocera <bnocera>
Component: Package ReviewAssignee: Adrian Reber <adrian>
Status: CLOSED DUPLICATE QA Contact: David Lawrence <dkl>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: fedora-extras-list
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2005-11-18 09:29:42 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
spec patch
none
spec patch none

Description Bastien Nocera 2005-11-10 19:10:29 UTC
Spec Name or Url: http://files.hadess.net/redhat/perso/spec/fdupes.spec
SRPM Name or Url: http://files.hadess.net/redhat/perso/source/fdupes-1.40-1.src.rpm
Description:
FDUPES is a program for identifying or deleting duplicate files residing
within specified directories.

Comment 1 Adrian Reber 2005-11-11 17:10:50 UTC
Will also attach a patch.

Another problem is that fdupes is not GPL as the spec files claims it to be.

Comment 2 Adrian Reber 2005-11-11 17:14:29 UTC
Created attachment 120952 [details]
spec patch

Changes:
- Group didn't exist
- BR were bogus
- BuildRoot changed
- honour RPM_OPT_FLAGS
- using macros not hardcoded paths
- added -p to install to preserve timestamps
- consistent use of RPM_BUILD_ROOT
- correct version in changelog

Comment 3 Bastien Nocera 2005-11-11 17:25:15 UTC
You uploaded the .spec file directly, which has no changes compared to mine...

Comment 4 Adrian Reber 2005-11-11 17:29:15 UTC
Created attachment 120954 [details]
spec patch

another try

Comment 5 Adrian Reber 2005-11-17 18:34:19 UTC
So can this be closed if Simon in
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=173080 maintains this?

Comment 6 Bastien Nocera 2005-11-18 09:29:42 UTC
Sure thing.

*** This bug has been marked as a duplicate of 173080 ***