Bug 172871
| Summary: | Review Request: driftnet | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Bastien Nocera <bnocera> | ||||
| Component: | Package Review | Assignee: | Adrian Reber <adrian> | ||||
| Status: | CLOSED RAWHIDE | QA Contact: | David Lawrence <dkl> | ||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | medium | ||||||
| Version: | rawhide | CC: | atennent, fedora-extras-list | ||||
| Target Milestone: | --- | ||||||
| Target Release: | --- | ||||||
| Hardware: | All | ||||||
| OS: | Linux | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2006-04-03 12:45:27 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Bug Depends On: | |||||||
| Bug Blocks: | 163779 | ||||||
| Attachments: |
|
||||||
|
Description
Bastien Nocera
2005-11-10 19:12:22 UTC
I will attach a patch for the spec file because it had just to many differences with the packaging guidelines to list them all here. Created attachment 120944 [details]
spec patch
The changes are:
- added URL
- added full URL for source0
- changed buildroot
- added requires %{_bindir}/consolehelper
- fixed description (< 80 characters)
- %setup -q
- honour RPM_OPT_FLAGS
- parallel build
- use of macros instead of hardcoded paths
- added clean section
That was pretty gross indeed. I should really have checked the spec file before putting it there ;) Thanks Adrian. Spec Name or Url: http://files.hadess.net/redhat/perso/spec/driftnet.spec SRPM Name or Url: http://files.hadess.net/redhat/perso/source/driftnet-0.1.6-5.src.rpm - builds in mock - source matches upstream - spec looks good - additional sources and patch look good - clean installation and removal Not approving yet as following makes me nervous, especially as this is running as root: /builddir/build/BUILD/driftnet-0.1.6/driftnet.c:588: warning: the use of `tmpnam' is dangerous, better use `mkstemp' http://mirror.espri.arizona.edu/gentoo/rsync/net-analyzer/driftnet/files/driftnet-0.1.6-tmpnam-is-bad.diff That's a gentoo patch for the tmpnam issue. Yay for the gentoo patch which doesn't clean up after itself... The mkdtemp in the gentoo patch didn't prefix the template with the user's tempdir. Updated packages: http://files.hadess.net/redhat/perso/source/driftnet-0.1.6-6.src.rpm http://files.hadess.net/redhat/perso/spec/driftnet.spec Adrian, do you want me to fix more compilation warnings with that, or? * rpmlint is almost happy: W: driftnet conffile-without-noreplace-flag /etc/security/console.apps/driftnet W: driftnet no-dependency-on usermode-consoleonly (can be ignored from my point of view) * clean installation and removal * builds in "mock -r fedora-development-i386-core" * source matches upstream * spec looks good (almost; see below) * patches look sane APPROVED driftnet-0.1.6-pam.config: using "auth include system-auth" instead of "auth required pam_stack.so service=system-auth" like other applications from rawhide would be a good idea. The other warnings are not nice but at least they do not say that it is a security risk to use them. If you like you can of course fix more warnings :-) One more fix would be necessary before you upload it. There is a rm -rf in %prep this should be moved to the beginning of %install. Any particular reason why this package is not yet imported and built ? *** Bug 187684 has been marked as a duplicate of this bug. *** Pushed to CVS in devel. |