Bug 1728774
| Summary: | Add button already/always enabled while adding a new Service Catalog Item | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Red Hat CloudForms Management Engine | Reporter: | Hilda Stastna <hstastna> | ||||
| Component: | UI - OPS | Assignee: | Hilda Stastna <hstastna> | ||||
| Status: | CLOSED ERRATA | QA Contact: | Niyaz Akhtar Ansari <nansari> | ||||
| Severity: | low | Docs Contact: | Red Hat CloudForms Documentation <cloudforms-docs> | ||||
| Priority: | medium | ||||||
| Version: | 5.10.0 | CC: | bmidwood, hkataria, lavenel, mpovolny, obarenbo, simaishi | ||||
| Target Milestone: | GA | ||||||
| Target Release: | 5.11.0 | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | 5.11.0.18 | Doc Type: | If docs needed, set a value | ||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2019-12-12 13:36:46 UTC | Type: | Bug | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | Bug | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | CFME Core | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Attachments: |
|
||||||
New commit detected on ManageIQ/manageiq-ui-classic/master: https://github.com/ManageIQ/manageiq-ui-classic/commit/d3c3878c7cde6f682c6e25928b7c90a4c01b664f commit d3c3878c7cde6f682c6e25928b7c90a4c01b664f Author: Hilda Stastna <hstastna> AuthorDate: Thu Apr 18 12:17:25 2019 -0400 Commit: Hilda Stastna <hstastna> CommitDate: Thu Apr 18 12:17:25 2019 -0400 Make Add button respond properly on changes while adding Catalog Item Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1728774 Also add new copy_params_if_present method to params helper app/controllers/catalog_controller.rb | 17 +- app/helpers/params_helper.rb | 11 + 2 files changed, 21 insertions(+), 7 deletions(-) New commit detected on ManageIQ/manageiq-ui-classic/ivanchuk: https://github.com/ManageIQ/manageiq-ui-classic/commit/1dd59484fdb52806e3c0a0319a028f780c4d2cf2 commit 1dd59484fdb52806e3c0a0319a028f780c4d2cf2 Author: Harpreet Kataria <hkataria> AuthorDate: Tue Jul 30 09:19:31 2019 -0400 Commit: Harpreet Kataria <hkataria> CommitDate: Tue Jul 30 09:19:31 2019 -0400 Merge pull request #5472 from hstastna/Add_button_enabled_Service_Catalog_Item Make Add button respond properly on changes while adding Catalog Item (cherry picked from commit 9ecceb4ef4c14278f35adb11e1c2c032ce05bb71) https://bugzilla.redhat.com/show_bug.cgi?id=1728774 app/controllers/catalog_controller.rb | 17 +- app/helpers/params_helper.rb | 11 + spec/controllers/catalog_controller_spec.rb | 90 +- 3 files changed, 106 insertions(+), 12 deletions(-) Verified in Version 5.11.0.19.20190813184334_ed72c9f Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHBA-2019:4199 |
Created attachment 1589156 [details] Add button is already (always) enabled while adding a new Service Catalog Item, even when there is nothing to add Description of problem: Add button is already (always) enabled while adding a new Service Catalog Item, even when there is nothing to add, because we haven't filled in anything, not even the required fields. This behavior is not consistent with other screens. For adding Catalog Bundles, there is a similar problem: however, when first time in, the Add button is disabled (which is right), after filling in some info and deleting it from some form (for example Name), Add button does not respond properly: it remains enabled, but there is nothing to add! Version-Release number of selected component (if applicable): 5.9, 5.10, 5.11 How reproducible: 100% Steps to Reproduce: 1. Go to Services > Catalogs > Catalog Items accordion 2. Configuration > Add a New Catalog Item 3. Choose some Catalog Item Type, except Ansible Playbook Actual results: Add button already enabled even if you entered nothing in the fields or chose from the drop downs. Similar issue for adding Catalog Bundles. Expected results: Add button should be disabled when first time in, and it should properly respond to user's filling in the required info. Additional info: If we click on the button, error flash messages about missing info or about empty fields are displayed, so it works good, at least. It does not allow you to add Catalog Item without the required info. Also, this bug is not present for Ansible Playbook Catalog Item type, where it works properly (because of different implementation of this screen - angular). And this is NOT a regression.