Bug 1728958
| Summary: | Hot unplug vfio-pci NIC devices from sev guest will cause qemu-kvm: sev_ram_block_removed: failed to unregister region | ||
|---|---|---|---|
| Product: | Red Hat Enterprise Linux 8 | Reporter: | Pei Zhang <pezhang> |
| Component: | qemu-kvm | Assignee: | Alex Williamson <alex.williamson> |
| Status: | CLOSED ERRATA | QA Contact: | Pei Zhang <pezhang> |
| Severity: | high | Docs Contact: | |
| Priority: | high | ||
| Version: | 8.1 | CC: | alex.williamson, chayang, ehabkost, jinzhao, juzhang, knoel, leiyang, rbalakri, virt-maint, zhguo |
| Target Milestone: | rc | ||
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | qemu-kvm-2.12.0-82.module+el8.1.0+3738+0d8c0249 | Doc Type: | If docs needed, set a value |
| Doc Text: | Story Points: | --- | |
| Clone Of: | 1728947 | Environment: | |
| Last Closed: | 2019-11-05 20:51:02 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 1728947 | ||
| Bug Blocks: | |||
|
Description
Pei Zhang
2019-07-11 06:26:10 UTC
Versions: 4.18.0-114.el8.x86_64 qemu-kvm-2.12.0-81.module+el8.1.0+3619+dfe1ae01.x86_64 The issue seems to be harmless, code was added to skip assigned device mmio regions from sev mapping when added, but the reciprocal code on removal was missed. Please test if this brew build resolves the warning: https://brewweb.engineering.redhat.com/brew/taskinfo?taskID=22630995 (In reply to Alex Williamson from comment #3) > The issue seems to be harmless, code was added to skip assigned device mmio > regions from sev mapping when added, but the reciprocal code on removal was > missed. Please test if this brew build resolves the warning: > https://brewweb.engineering.redhat.com/brew/taskinfo?taskID=22630995 This build works well, the issue is gone. Thanks. Best regards, Pei Thanks for testing! Posted upstream: https://lists.gnu.org/archive/html/qemu-devel/2019-07/msg03451.html Fixed in upstream commit which will be included in 4.1-rc1
commit 56e2ec9488b3b281130e064929f8ae5595d6ac39
Author: Alex Williamson <alex.williamson>
Date: Mon Jul 15 08:28:39 2019 -0600
target/i386: sev: Do not unpin ram device memory region
The commit referenced below skipped pinning ram device memory when
ram blocks are added, we need to do the same when they're removed.
Cc: Brijesh Singh <brijesh.singh>
Cc: Paolo Bonzini <pbonzini>
Fixes: cedc0ad539af ("target/i386: sev: Do not pin the ram device memory region")
Signed-off-by: Alex Williamson <alex.williamson>
Message-Id: <156320087103.2556.10983987500488190423.stgit>
Reviewed-by: Singh, Brijesh <brijesh.singh>
Signed-off-by: Paolo Bonzini <pbonzini>
(In reply to Alex Williamson from comment #6) > Fixed in upstream commit which will be included in 4.1-rc1 This is a RHEL BZ, isn't a backport necessary? (In reply to Eduardo Habkost from comment #7) > (In reply to Alex Williamson from comment #6) > > Fixed in upstream commit which will be included in 4.1-rc1 > > This is a RHEL BZ, isn't a backport necessary? Yes, I didn't immediately recognize that this was a RHEL bz rather than RHAV since the initial report was based on QEMU 4.0. Moving back to assigned. Verified by qemu-kvm-2.12.0-82.module+el8.1.0+3738+0d8c0249.x86_64: Steps: 1. Boot guest with sev and device assignment 2. Hot unplug vfio-pci devices, qemu works well. (qemu) device_del pf1 (qemu) device_del pf2 (qemu) 3. Reboot/shutdown guest, works well. No any error. So this bug has been fixed very well. Move to 'VERIFIED'. Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHSA-2019:3345 |