Bug 1728991

Summary: Semantic error when diskdevstat were used
Product: Red Hat Enterprise Linux 8 Reporter: Robin Hack <rhack>
Component: systemtapAssignee: Frank Ch. Eigler <fche>
systemtap sub component: system-version QA Contact: qe-baseos-tools-bugs
Status: CLOSED CURRENTRELEASE Docs Contact:
Severity: unspecified    
Priority: unspecified CC: dsmith, lberk, mcermak, mjw
Version: 8.2Keywords: Triaged
Target Milestone: rc   
Target Release: 8.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2020-03-18 23:57:40 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1785287    
Bug Blocks:    

Description Robin Hack 2019-07-11 07:29:04 UTC
Description of problem:
Hello. One of my test just uses:
# diskdevstat 5 60

which fails

Version-Release number of selected component (if applicable):
# rpm -qf /usr/share/systemtap/tapset/linux/vfs.stp
systemtap-client-4.1-3.el8.x86_64
systemtap-devel-4.1-3.el8.x86_64

How reproducible:
always

Steps to Reproduce:
1. run diskdevstat 5 60
3.

Actual results:
semantic error: failed to retrieve location attribute for 'file' [man error::dwarf]: identifier '$file' at /usr/share/systemtap/tapset/linux/vfs.stp:1055:19
        dieoffset: 0x36a4919 from /usr/lib/debug/lib/modules/4.18.0-107.el8.x86_64/vmlinux
        function: vfs_write at fs/read_write.c:546:3 inlined by vfs_write at fs/read_write.c:533:9
        source: 	dev = __file_dev($file)
                	                 ^

semantic error: unresolved type : identifier '$file' at :1055:19
        source: 	dev = __file_dev($file)
                	                 ^

Pass 2: analysis failed.  [man error::pass2]
Number of similar error messages suppressed: 6.
Rerun with -v to see them.


Expected results:
no error? :)

Additional info:

Comment 1 Martin Cermak 2019-07-11 12:37:51 UTC
This feels like a dwarf quality problem (of bz1652740 type).  Some of them are work-aroundble using prologue-searching (stap -P).  Where does your diskdevstat come from?  Not sure what that actually is. It doesn't look like a part of systemtap (examples), neither it seems to be a packaged binary installing to /usr/bin/.

Comment 2 Frank Ch. Eigler 2019-07-11 12:40:08 UTC
Robin, please share the script, and the systemtap / kernel / gcc versions.

Comment 3 Frank Ch. Eigler 2019-07-11 12:42:30 UTC
Ah I see the stap & kernel versions up there. 

The kernel version is beyond 4.18.0-85, which was the first one affected by a gcc rebase (8.2.1->8.3.1).  Could be a dupe of bug #1709831.

Comment 5 Frank Ch. Eigler 2020-02-24 14:50:53 UTC
Robin, thanks.  I was missing that this stap script comes from tuned-utils-systemtap.
(Any idea why don't we just include those as systemtap sample scripts?)

With the 4.18.0-172.el8 kernel, this now passes.  Suggesting CLOSED/CURRENTRELEASE.