Bug 1729292
Summary: | Broken rbd_list method in virsh vol-list command | ||
---|---|---|---|
Product: | [Community] Virtualization Tools | Reporter: | Jules <jules> |
Component: | libvirt | Assignee: | Libvirt Maintainers <libvirt-maint> |
Status: | CLOSED NEXTRELEASE | QA Contact: | |
Severity: | unspecified | Docs Contact: | |
Priority: | unspecified | ||
Version: | unspecified | CC: | berrange, crobinso, jdillama, jtomko, libvirt-maint, tburke |
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | All | ||
OS: | All | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | If docs needed, set a value | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2019-07-15 07:44:06 UTC | Type: | Bug |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
Jules
2019-07-11 19:17:23 UTC
CCing danpb who wrote the patch, and dillaman who had patches around the same time. Maybe someone has a setup to test I believe this patch should fix it, but I have not tested it: https://www.redhat.com/archives/libvir-list/2019-July/msg00811.html I will test whatever you like me to test. We urgently need to get all Ceph RBD features working again. Can you give me direct links to your diff patches, so i can add them to my quilt patchsets. Pushed to git master as: commit 9b7c4048fa0559fd81d57b7f7d13b1dccd6a99b2 Author: Ján Tomko <jtomko> CommitDate: 2019-07-12 17:09:42 +0200 storage: rbd: actually index the array when iterating over it https://bugzilla.redhat.com/show_bug.cgi?id=1729292 Fixes: 3aa190f2a43a632b542a6ba751a6c3ab4d51f1dd Signed-off-by: Ján Tomko <jtomko> Reviewed-by: Daniel P. Berrangé <berrange> git describe: v5.5.0-123-g9b7c4048fa It can be fetched using the URLs mentioned here: https://libvirt.org/git/?p=libvirt.git;a=summary or you can wait a few minutes until it shows up on the github mirror. And with the latest commit it could even compile! commit b632e00ffbfee7b11074bf4ca5f4399e929bbe53 Author: Ján Tomko <jtomko> CommitDate: 2019-07-12 17:51:39 +0200 storage: rbd: do not attempt to dereference a non-pointer My commit 9b7c4048fa0559fd81d57b7f7d13b1dccd6a99b2 was too blind and my librbd was not new enough to actually compile this part. Signed-off-by: Ján Tomko <jtomko> git describe: v5.5.0-126-gb632e00ffb awww, you reverted? :-( Recent ceph rbd build i use: librbd-devel-14.2.1-1 I can confirm that your patch fixes my issue. |