Bug 1729341

Description of problem:
A generic object with a button to a dialogue is causing a Fatal error after clicking the Submit button.
Happens even after migration upgrade to 5.10.6.
In CFME 5.10.6: After hitting Submit in Generic Object with a Dialog(via generic object Button) it redirects into a URL where it uses the 'Generic Object ID' as the Service ID
 https://cfme.example.com/api/services/301000000000163   #301000000000163 is a Generic Object ID and not the Service Id.

* FATAL in 5.10.6 log/production.log
[----] F, [2019-07-11T10:36:38.424553 #12777:1888f50] FATAL -- : Error caught: [ActiveRecord::RecordNotFound] Couldn't find Service with 'id'=301000000000163
(cfme-gemset dump)

* FATAL in 5.9.9 log/production.log
[----] F, [2019-07-08T16:19:53.169019 #475:bdb12c] FATAL -- : Error caught: [ActiveRecord::RecordNotFound] Couldn't find Service with 'id'=301000000000146
(cfme-gemset dump)

* log/apache/ssl_error.log
(Multiple [proxy_http:error] and [proxy:error] errors. Unsure if related)

Full sosreport available in the linked case for both versions. 

There are similar buzilla cases:

* https://bugzilla.redhat.com/show_bug.cgi?id=1595213
This was seen in the 5.9.9 version with the extra "generic_object_id" param and value.
After upgrade that extra field and value are gone.

5.9:
/service/show/301000000000401?display=generic_objects&generic_object_id=301000000000146
5.10:
/service/show/301000000000163?display=generic_objects

* https://bugzilla.redhat.com/show_bug.cgi?id=1582873
This created the service via API instead of rails. See the reproduce steps below.
The "worksforme" in comment 15 doesn't work anymore for CFME 5.10.5 and 5.10.6
Assuming that multiple changes to DRO added complexity not satisfied by the way this was setup? 


Version-Release number of selected component (if applicable):
Original: 5.9.9.3-20190503150855_af8378f
Updated:  5.10.6.1-20190621202107_58f5bbc


How reproducible:
Create a Generic Object, service, dialogue, and instance in custom domain.
No method for that instance. CustomDomain/RH/RH/LogMe


Steps to Reproduce:
1. In Automation > Automate > Generic Object create a new generic object called "Network"
2. Create a Service and associate it with the Generic Object above via rails
---
$ vmdb
$ rails c
irb(main):001:0> $evm = MiqAeMethodService::MiqAeService.new(MiqAeEngine::MiqAeWorkspaceRuntime.new)
irb(main):001:0>gobj_cls = $evm.vmdb(:generic_object_definition).find_by_name('Network')
irb(main):001:0>data = {"name" => "frontend"}       
irb(main):001:0>new_gobj = gobj_cls.create_object(data)
irb(main):001:0>new_service = $evm.vmdb(:service).create(:name => "Network frontend")
irb(main):001:0>new_service.display = true
irb(main):001:0>new_gobj.add_to_service(new_service)
---

3. Create a simple automation method in custom Domain:

Namespace: RH
Class: RH
Instance: LogMe

4. Create a simple Service Dialog. Only has a one simple text field.
5. Create a Generic Object button for the "Network" Generic Object with the following details:

Dialog: Use the Service Dialog created in step 4


Object Details
Text: Network objButton
System/Process/: Request
Message: create
Request: call_instance

Attribute/Value Pairs
1 class RH
2 instance LogMe
3 namespace RH

6. Go to Services > My Services and select the Service created in step 2 "Network frontend".
7. In the service "Network frontend" details, click Instances under the Generic Objects table.
8. Click the Generic Object link "frontend"
9. Click on the Button created in step5, "Network objButton"

Should be able to see the error after hitting 'Submit'

Actual results:
Errors out in the UI and logs. The wrong URL is generated.

Expected results:
Continue with the workflow without error.


Additional info:
Using the steps given by the customer this works for us in versions 5.10.6 with a fresh install of the CFME appliance.