Bug 1729390

Summary: Build failed with GenericBuildFailed reason when Configuring wrong Post Commit Build Hooks
Product: OpenShift Container Platform Reporter: wewang <wewang>
Component: BuildAssignee: Adam Kaplan <adam.kaplan>
Status: CLOSED WONTFIX QA Contact: wewang <wewang>
Severity: low Docs Contact:
Priority: low    
Version: 4.2.0CC: aos-bugs, wzheng
Target Milestone: ---   
Target Release: 4.3.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard: good-first-issue
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2020-01-22 15:14:37 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:

Description wewang 2019-07-12 07:42:35 UTC
Description of problem:
Build failed with StatusReason GenericBuildFailed when Configuring wrong Post Commit Build Hooks

Version-Release number of selected component (if applicable):

How reproducible:

Steps to Reproduce:
1.Create app with wrong Post Commit Build Hooks

    "postCommit": {
       "script": "bundle exec invalid test"

2. Check the build
$ oc get builds
NAME                  TYPE     FROM          STATUS                        STARTED          DURATION
ruby-sample-build-1   Source   Git@787f1be   Failed (GenericBuildFailed)   12 minutes ago   1m50s


Actual results:
Build Failed with GenericBuildFailed reason

Expected results:
Build Failed with PostCommitHookFailed reason

Additional info:

Comment 1 wewang 2019-07-12 07:49:40 UTC
Seems in 4.x, just defined StatusReasonPostCommitHookFailed StatusReason = "PostCommitHookFailed" const, but it's not used.

Fyi, when build update that sets phase status failed should contain log snippet data, but cannot find any logSnippet data from logs of pod in  openshift-controller-manager namespace.

Comment 5 Adam Kaplan 2020-01-22 15:14:37 UTC
Closing this bug due to current engineering priorities, severity, availability of suitable workarounds and lack of customer cases. If this should be addressed, please reopen and provide additional details.