Bug 172994

Summary:	Review Request: pork - Console based AIM client
Product:	[Fedora] Fedora	Reporter:	Luke Macken <lmacken>
Component:	Package Review	Assignee:	Aurelien Bompard <gauret>
Status:	CLOSED NEXTRELEASE	QA Contact:	David Lawrence <dkl>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	fedora-extras-list, pfrields
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
URL:	http://dev.ojnk.net
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2005-11-15 01:01:50 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	163779

Description Luke Macken 2005-11-11 21:43:44 UTC

Spec Name or Url: http://people.redhat.com/lmacken/pork.spec
SRPM Name or Url: http://people.redhat.com/lmacken/pork-0.99.8.1-1.src.rpm
Description:

pork is an ncurses-based AOL instant messenger client. It uses the
OSCAR protocol (the one the windows client uses) to access AIM. Pork
features Perl scripting; an online help system; the ability to
configure nearly all aspects of the program's look-and-feel; an alias
system; and a powerful, fully-configurable key binding system. It
supports being logged in with more than one screen name at the same
time. The default look-and-feel of the client is modeled after the
ircII IRC client. Anyone comfortable using ircII (or any clients
derived from it -- e.g., epic, BitchX, etc.) will feel comfortable using
pork.

Comment 1 Aurelien Bompard 2005-11-12 14:29:37 UTC

* Use http://dl.sourceforge.net as the server for the Source tag, it allows
direct download

* Own the %{_datadir}/%{name} directory

* Build fails in mock :
/usr/bin/install -D -p -m 0755 doc/pork.1
/var/tmp/pork-0.99.8.1-1-root-mockbuild/usr/share/man/man1/
/usr/bin/install: cannot overwrite directory
`/var/tmp/pork-0.99.8.1-1-root-mockbuild/usr/share/man/man1/' with non-directory

Comment 2 Luke Macken 2005-11-14 01:00:24 UTC

Updated; builds clean in mock for me.

http://people.redhat.com/lmacken/pork-0.99.8.1-2.src.rpm
http://people.redhat.com/lmacken/pork.spec

Comment 3 Aurelien Bompard 2005-11-14 19:31:13 UTC

One last thing : please include the text of the license in %doc (at least). For
example, you could add to the %files section the following line:
%doc COPYING NEWS TODO CONTRIBUTERS STYLE README AUTHORS
QUICK_START is already packaged in /usr/share/pork, and ChangeLog is empty for
the moment.

Comment 4 Luke Macken 2005-11-14 21:26:27 UTC

Woops.. definitely forgot the documentation.  Fixed.

http://people.redhat.com/lmacken/pork-0.99.8.1-3.src.rpm
http://people.redhat.com/lmacken/pork.spec

Comment 5 Aurelien Bompard 2005-11-14 22:22:11 UTC

> Woops.. definitely forgot the documentation.

That's what the review process is for :)

Review for release 3:
* RPM name is OK
* Source pork-0.99.8.1.tar.gz is the same as upstream
* This is the latest version
* Builds fine in mock
* File list of pork looks OK
* Works fine
APPROVED

Comment 6 Luke Macken 2005-11-15 01:01:50 UTC

Imported.  Thanks!