Bug 1730229

Summary:	Fix memory leaks that are present even after an xlator fini [client side xlator]
Product:	[Community] GlusterFS	Reporter:	Mohammed Rafi KC <rkavunga>
Component:	core	Assignee:	bugs <bugs>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	high	Docs Contact:
Priority:	unspecified
Version:	7	CC:	bugs, rkothiya, sunkumar
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:	1716695	Environment:
Last Closed:	2020-02-10 17:42:08 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1716695
Bug Blocks:

Description Mohammed Rafi KC 2019-07-16 09:07:10 UTC

+++ This bug was initially created as a clone of Bug #1716695 +++

Description of problem:

There are quite a few memory leaks identified for client side xlators.
1) xlators/cluster/afr/src/afr.c ---> this->local_pool is not freed
2) xlators/cluster/ec/src/ec.c  ----> this->itable is not freed
3) protocol/client/src/client.c ----> this->local_pool is not freed

I will add more to this list in case if I found any other leaks

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

--- Additional comment from Worker Ant on 2019-06-04 00:19:02 UTC ---

REVIEW: https://review.gluster.org/22806 (afr/fini: Free local_pool data during an afr fini) posted (#1) for review on master by mohammed rafi  kc

--- Additional comment from Worker Ant on 2019-06-04 00:20:15 UTC ---

REVIEW: https://review.gluster.org/22807 (ec/fini: Free itable during an ec fini) posted (#1) for review on master by mohammed rafi  kc

--- Additional comment from Worker Ant on 2019-06-17 07:06:11 UTC ---

REVIEW: https://review.gluster.org/22806 (afr/fini: Free local_pool data during an afr fini) merged (#3) on master by Pranith Kumar Karampuri

--- Additional comment from Worker Ant on 2019-06-20 08:38:02 UTC ---

REVIEW: https://review.gluster.org/22904 (graph/shd: Use glusterfs_graph_deactivate to free the xl rec) posted (#1) for review on master by mohammed rafi  kc

--- Additional comment from Worker Ant on 2019-06-27 06:04:44 UTC ---

REVIEW: https://review.gluster.org/22904 (graph/shd: Use glusterfs_graph_deactivate to free the xl rec) merged (#8) on master by Pranith Kumar Karampuri

--- Additional comment from Worker Ant on 2019-06-27 13:53:18 UTC ---

REVIEW: https://review.gluster.org/22968 (graph/shd: Use top down approach while cleaning xlator) posted (#1) for review on master by mohammed rafi  kc

--- Additional comment from Worker Ant on 2019-06-27 18:25:41 UTC ---

REVIEW: https://review.gluster.org/22968 (graph/shd: Use top down approach while cleaning xlator) merged (#3) on master by mohammed rafi  kc

Comment 1 Worker Ant 2019-07-16 09:19:31 UTC

REVIEW: https://review.gluster.org/23056 (graph/shd: Use glusterfs_graph_deactivate to free the xl rec) posted (#2) for review on release-7 by mohammed rafi  kc

Comment 2 Worker Ant 2019-07-16 09:20:46 UTC

REVIEW: https://review.gluster.org/23057 (graph/shd: Use top down approach while cleaning xlator) posted (#2) for review on release-7 by mohammed rafi  kc

Comment 3 Worker Ant 2019-07-16 09:21:58 UTC

REVIEW: https://review.gluster.org/23058 (glusterd/svc: update pid of mux volumes from the shd process) posted (#2) for review on release-7 by mohammed rafi  kc

Comment 4 Worker Ant 2019-07-24 05:55:34 UTC

REVISION POSTED: https://review.gluster.org/23058 (glusterd/svc: update pid of mux volumes from the shd process) posted (#3) for review on release-7 by mohammed rafi  kc

Comment 5 Worker Ant 2019-07-24 10:23:52 UTC

REVIEW: https://review.gluster.org/23056 (graph/shd: Use glusterfs_graph_deactivate to free the xl rec) merged (#3) on release-7 by Rinku Kothiya

Comment 6 Worker Ant 2019-07-24 10:27:05 UTC

REVIEW: https://review.gluster.org/23057 (graph/shd: Use top down approach while cleaning xlator) merged (#3) on release-7 by Rinku Kothiya

Comment 7 Sunny Kumar 2020-02-10 17:42:08 UTC

Patch is merged closing this bug now.