Bug 1730813
| Summary: | Default service dialog values not included in EVM when 'refresh_dialog_fields' action invoked | |||
|---|---|---|---|---|
| Product: | Red Hat CloudForms Management Engine | Reporter: | Josh Carter <jocarter> | |
| Component: | API | Assignee: | Tina Fitzgerald <tfitzger> | |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Parthvi Vala <pvala> | |
| Severity: | high | Docs Contact: | Red Hat CloudForms Documentation <cloudforms-docs> | |
| Priority: | high | |||
| Version: | 5.10.6 | CC: | dmetzger, mshriver, obarenbo, pvala, simaishi, tfitzger | |
| Target Milestone: | GA | Keywords: | TestOnly, ZStream | |
| Target Release: | 5.11.0 | |||
| Hardware: | All | |||
| OS: | All | |||
| Whiteboard: | ||||
| Fixed In Version: | 5.11.0.16 | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | ||
| Clone Of: | ||||
| : | 1731977 (view as bug list) | Environment: | ||
| Last Closed: | 2019-12-13 14:54:54 UTC | Type: | Bug | |
| Regression: | --- | Mount Type: | --- | |
| Documentation: | --- | CRM: | ||
| Verified Versions: | Category: | Bug | ||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | ||
| Cloudforms Team: | CFME Core | Target Upstream Version: | ||
| Embargoed: | ||||
| Bug Depends On: | ||||
| Bug Blocks: | 1731977 | |||
|
Comment 5
CFME Bot
2019-07-18 18:24:11 UTC
New commits detected on ManageIQ/manageiq/master: https://github.com/ManageIQ/manageiq/commit/eb51c011f366d365e38527978466919b91b63b50 commit eb51c011f366d365e38527978466919b91b63b50 Author: Erik Clarizio <eclarizi> AuthorDate: Thu Jul 18 13:06:03 2019 -0400 Commit: Erik Clarizio <eclarizi> CommitDate: Thu Jul 18 13:06:03 2019 -0400 Initialize static field values before loading values into the field https://bugzilla.redhat.com/show_bug.cgi?id=1730813 app/models/dialog.rb | 8 + app/models/dialog_field.rb | 6 + app/models/resource_action_workflow.rb | 5 +- spec/models/dialog_field_spec.rb | 52 + spec/models/dialog_spec.rb | 24 + spec/models/resource_action_workflow_spec.rb | 5 + 6 files changed, 99 insertions(+), 1 deletion(-) https://github.com/ManageIQ/manageiq/commit/bfaff4357f31319e627706b8303dd8476f30b562 commit bfaff4357f31319e627706b8303dd8476f30b562 Author: Erik Clarizio <eclarizi> AuthorDate: Thu Jul 18 13:43:59 2019 -0400 Commit: Erik Clarizio <eclarizi> CommitDate: Thu Jul 18 13:43:59 2019 -0400 Refactor #load_dialog method into smaller manageable private methods https://bugzilla.redhat.com/show_bug.cgi?id=1730813 app/models/resource_action_workflow.rb | 60 +- spec/models/resource_action_workflow_spec.rb | 1 + 2 files changed, 33 insertions(+), 28 deletions(-) https://github.com/ManageIQ/manageiq/commit/a86428f96982c4947052bdd0f65cdeb6b54d01c3 commit a86428f96982c4947052bdd0f65cdeb6b54d01c3 Author: Erik Clarizio <eclarizi> AuthorDate: Thu Jul 18 14:13:36 2019 -0400 Commit: Erik Clarizio <eclarizi> CommitDate: Thu Jul 18 14:13:36 2019 -0400 Remove unnecessary spec https://bugzilla.redhat.com/show_bug.cgi?id=1730813 spec/models/dialog_field_spec.rb | 21 +- 1 file changed, 4 insertions(+), 17 deletions(-) https://github.com/ManageIQ/manageiq/commit/7298e4f6cf952372e0ab96c25324598318eb30ce commit 7298e4f6cf952372e0ab96c25324598318eb30ce Author: Erik Clarizio <eclarizi> AuthorDate: Thu Jul 18 18:48:50 2019 -0400 Commit: Erik Clarizio <eclarizi> CommitDate: Thu Jul 18 18:48:50 2019 -0400 Rename parameter for more accurate meaning and pass false for refresh https://bugzilla.redhat.com/show_bug.cgi?id=1730813 app/models/dialog.rb | 4 +- app/models/resource_action_workflow.rb | 2 +- spec/models/dialog_spec.rb | 8 +- spec/models/resource_action_workflow_spec.rb | 10 +- 4 files changed, 10 insertions(+), 14 deletions(-) FIXED. Verified on 5.11.0.17.20190730152352_93b1c30. |