Bug 1731017
Summary: | Moving reports to a different menu does not work as expected | ||
---|---|---|---|
Product: | Red Hat CloudForms Management Engine | Reporter: | Parthvi Vala <pvala> |
Component: | Reporting | Assignee: | drew uhlmann <duhlmann> |
Status: | CLOSED CURRENTRELEASE | QA Contact: | Parthvi Vala <pvala> |
Severity: | high | Docs Contact: | Red Hat CloudForms Documentation <cloudforms-docs> |
Priority: | medium | ||
Version: | 5.11.0 | CC: | duhlmann, obarenbo, simaishi, yrudman |
Target Milestone: | GA | ||
Target Release: | 5.11.0 | ||
Hardware: | Unspecified | ||
OS: | Unspecified | ||
Whiteboard: | |||
Fixed In Version: | 5.11.0.19 | Doc Type: | If docs needed, set a value |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2019-12-13 14:58:10 UTC | Type: | Bug |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | Bug | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | CFME Core | Target Upstream Version: | |
Embargoed: |
Description
Parthvi Vala
2019-07-18 06:59:34 UTC
Incidentally, in case anyone's looking at this ticket, LJ's right about it, and it's a UI issue. The same report can have multiple nodes in the tree in some cases. I think it is back-end bug: report's menu structure kept in miq_group#settings which is Hash of report names. When we delete custom report we are not updating that field and name of deleted custom report still present in miq_group#settings. UI does not show that since actual report deleted. When new custom report with same name created - it would be shown in the old place. There is work around of this issue: after/before deleting custom report remove it from list of reports available for group by using "Edit report Menus" I'm confused because loading all MiqGroup settings after the destroy on https://github.com/ManageIQ/manageiq-ui-classic/blob/e7a3be000841c4b6f15f8d2a88a7c3dcf5e5939d/app/controllers/report_controller/reports.rb#L78, the settings all appear nil: MiqGroup.all.pluck(:settings) [----] D, [2019-07-30T14:25:56.771656 #48307:3ffa4c9752f8] DEBUG -- : (0.4ms) SELECT "miq_groups"."settings" FROM "miq_groups" => [nil, nil, nil, nil, nil, nil, nil, nil, nil, nil, nil, nil, nil, nil, nil, nil, nil, nil, nil, nil] New commit detected on ManageIQ/manageiq-ui-classic/ivanchuk: https://github.com/ManageIQ/manageiq-ui-classic/commit/b6888e07ec6d856944233ec45618f4a8ca79638e commit b6888e07ec6d856944233ec45618f4a8ca79638e Author: Martin Povolny <mpovolny> AuthorDate: Wed Aug 7 10:06:45 2019 -0400 Commit: Martin Povolny <mpovolny> CommitDate: Wed Aug 7 10:06:45 2019 -0400 Merge pull request #5950 from d-m-u/fixing_settings_hash_of_miq_group Remove report names from group settings hash when reports are deleted (cherry picked from commit 4cee794225b186ee70447013f9df25009de5ebef) https://bugzilla.redhat.com/show_bug.cgi?id=1731017 app/controllers/report_controller/reports.rb | 12 +- spec/controllers/miq_report_controller/reports_spec.rb | 15 + 2 files changed, 25 insertions(+), 2 deletions(-) FIXED. Verified on 5.11.0.19.20190813184334_ed72c9f. Thanks for fixing this. |