Bug 1731222

Summary: e2e flake: template tests
Product: OpenShift Container Platform Reporter: Matthew Staebler <mstaeble>
Component: TemplatesAssignee: Gabe Montero <gmontero>
Status: CLOSED ERRATA QA Contact: XiuJuan Wang <xiuwang>
Severity: high Docs Contact:
Priority: unspecified    
Version: 4.2.0CC: adam.kaplan, aos-bugs, bparees, deads, gmontero, jokerman, mfojtik, mmccomas, sttts, wzheng
Target Milestone: ---Keywords: Reopened
Target Release: 4.5.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard: buildcop
Fixed In Version: Doc Type: No Doc Update
Doc Text:
Story Points: ---
Clone Of:
: 1833824 (view as bug list) Environment:
Last Closed: 2020-07-13 17:11:03 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1833824    

Description Matthew Staebler 2019-07-18 16:54:18 UTC
Description of problem:
[Conformance][templates] test flakiness

https://prow.svc.ci.openshift.org/view/gcs/origin-ci-test/logs/release-openshift-origin-installer-e2e-aws-4.2/2104

Comment 1 Adam Kaplan 2019-07-18 17:29:48 UTC
Moving to openshift-apiserver

Error message:
```
failed condition: no kind is registered for the type v1.Template in scheme \"k8s.io/kubernetes/pkg/api/legacyscheme/scheme.go:29
```

Comment 2 David Eads 2019-07-18 18:02:52 UTC
@Adam  Can you elaborate on this transfer?  That's a client error in a template instance controller test.

Comment 3 Adam Kaplan 2019-07-18 20:09:30 UTC
Moving this to Templates, though we don't have a clear understanding of where the issue lies at this point in time.

Template instance controller logs have errors like "error syncing namespace, it will be retried: Operation cannot be fulfilled on namespaces "e2e-test-templates-q9c9g": the object has been modified; please apply your changes to the latest version and try again"

CC-ing sttts

Comment 4 Stefan Schimanski 2019-07-19 08:59:50 UTC
We have hope that https://github.com/openshift/openshift-controller-manager/pull/6 fixes this.

Comment 5 Stefan Schimanski 2019-07-19 13:19:14 UTC
Looks like they are gone. Closing.

Comment 6 Ben Parees 2020-04-20 03:02:25 UTC
The tests were never re-enabled:

https://github.com/openshift/origin/blob/master/test/extended/templates/templateinstance_readiness.go#L125

assigning this to Adam to re-enable the tests.  If they are still failing, then he can decide who needs to be chased.  But we need to do a better job of connecting the dots when we disable tests in the face of a bug, to ensure the tests get re-enabled when the bug is resolved, in the future.

Comment 7 Ben Parees 2020-04-20 03:03:05 UTC
(note there are numerous tests being skipped for this bug, i only flagged the first one above)

Comment 8 Gabe Montero 2020-04-23 13:34:36 UTC
8 of the 11 template extended tests passed in https://prow.svc.ci.openshift.org/view/gcs/origin-ci-test/pr-logs/pull/24912/pull-ci-openshift-origin-master-e2e-gcp/7434

will start triaging today

Comment 11 Gabe Montero 2020-05-10 21:47:16 UTC
re-enabled e2e sufficient verification

Comment 12 Gabe Montero 2020-05-11 14:24:20 UTC
WRT doc'ing this bz:

1) mainly, this bug centered around re-enabling existing template tests that were disabled during the 4.2 creation of OCM, followed by a collective forgetting to re-enable
2) the openshift-apiserver change is only needed for k8s 1.18 based master branch i.e. for 4.5 ... I discovered this need as part of the 4.5 dev cycle and it was fixed in the 4.5 cycle;
i.e. it should be considered as part of the overall k82 1.18 bump feature in OCP 4.5, and does not need to be documented as part of errata, etc.

So "NO DOC UPDATED NEEDED"

Comment 14 errata-xmlrpc 2020-07-13 17:11:03 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2020:2409