Bug 1731892
| Summary: | Restore or confirm test removals during openshift-controller-manager staging move | ||
|---|---|---|---|
| Product: | OpenShift Container Platform | Reporter: | Stefan Schimanski <sttts> |
| Component: | openshift-controller-manager | Assignee: | Gabe Montero <gmontero> |
| Status: | CLOSED ERRATA | QA Contact: | wewang <wewang> |
| Severity: | urgent | Docs Contact: | |
| Priority: | urgent | ||
| Version: | 4.2.0 | CC: | adam.kaplan, aos-bugs, bparees, mfojtik |
| Target Milestone: | --- | ||
| Target Release: | 4.2.0 | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | No Doc Update | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2019-10-16 06:30:16 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Stefan Schimanski
2019-07-22 10:05:23 UTC
And also confirm: https://github.com/openshift/origin/pull/23415#discussion_r305719917 https://github.com/openshift/origin/pull/23415#discussion_r305729673 I've addded Ben and Adam for opinions/awareness 1) regarding https://github.com/openshift/origin/pull/23415/commits/8f8abb5b9a3d07fa449d834b2c57a5ce142f460f#r305725441 yes I think we would want to add mysql_replica.go back into image_eco ... it was actually removed with https://github.com/openshift/origin/commit/96a6c8e20836f696959832492637ff3a447eb851#diff-a8a6852352f072d73d2f36a30fbb4858 via https://github.com/openshift/origin/pull/23404 2) same with https://github.com/openshift/origin/pull/23415/commits/8f8abb5b9a3d07fa449d834b2c57a5ce142f460f#diff-5fc899c05f7bf80c95fb6f30b3e1cf37L1 and postgresql_replica.go .... similarly it was removed via https://github.com/openshift/origin/pull/23404 The two items from comment #1 and smaller by comparison, the commenting out of `if !controller.CanCheckReadiness(object.Ref) {` in test/extended/templates/helpers.go and `//testutil.SetAdditionalAllowedRegistries(registryHostname)` in test/extended/builds/controllers.go The former template one might be ok to lose (need to investigate further though). seems like we would want to re-add allowed registries in the build controller test at first blush, but that file is new as well in 4.2, so need to track down where in 4.1 that came from. @Wen - only automated PR tests were updated in the above PR .... no QE verifications are necessary. PR is on the merge queue marked no doc update since this just augmented our automated test cases used during PR testing also, per my #comment 3 no QA involvement needed ... marking as verified Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHBA-2019:2922 |