Bug 1732277

Summary: Dev console should set Application as optional field when deploying an app
Product: OpenShift Container Platform Reporter: XiaochuanWang <xiaocwan>
Component: Dev ConsoleAssignee: cvogt
Status: CLOSED NOTABUG QA Contact: Gajanan More <gamore>
Severity: low Docs Contact:
Priority: unspecified    
Version: 4.2.0CC: aos-bugs, jokerman, mmccomas, nmukherj
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2019-09-04 13:56:05 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
standalone app is allowed to create from admin console
none
app could be joined to Application manually on Admin console. none

Description XiaochuanWang 2019-07-23 06:15:41 UTC 
Description of problem:
Dev console set the Application Name filed as required when deploying an app while Admin console doesn't have Application Name field. This is only to set as label which key is "app.kubernetes.io/part-of"

Version-Release number of selected component (if applicable):
4.2.0-0.nightly-2019-07-22-160516

How reproducible:
Always

Steps to Reproduce:
1. User login and switch to Development console. Click Add -> Deploy Image and check the field. (After created, check the label of DC which has "app.kubernetes.io/part-of")
2. Compare admin console. (From OperatorHub -> Developer Catalog -> choose an image to deploy). This will not create the label which key is "app.kubernetes.io/part-of"


Actual results:
1. "Application" is a required field. Label with key "app.kubernetes.io/part-of" is created automatically.
2. There is no "Application" field and there is no label "app.kubernetes.io/part-of"

Expected results:
1. "Application" should be an optional field.

Additional info:
After added the label with the same value for the key "app.kubernetes.io/part-of", Applications are connected.
Comment 1 XiaochuanWang 2019-07-23 06:27:10 UTC 
Created attachment 1592753 [details]
standalone app is allowed to create from admin console
Comment 2 XiaochuanWang 2019-07-23 06:28:06 UTC 
Created attachment 1592754 [details]
app could be joined to Application manually on Admin console.
Comment 3 XiaochuanWang 2019-07-23 06:46:01 UTC 
Sorry, no need compare to Admin console.
Comment 4 cvogt 2019-08-21 20:01:50 UTC 
The admin and dev console forms for creating an s2i app now share the same input fields and application name is a required field.

While the field is required, we have another issue to track providing a sensible default value: https://jira.coreos.com/browse/ODC-1646

The instantiate template form is still different and does not apply the same labels or request the application name be entered
Comment 5 cvogt 2019-08-31 02:24:29 UTC 
Application name is no longer required and when possible a default value is provided.