Bug 1732298

Summary:	after update to libvirt 5.5.0 unable to start VM connected to openvswitch with vlan tag
Product:	[Community] Virtualization Tools	Reporter:	dualdm <dualdm>
Component:	libvirt	Assignee:	Daniel Berrangé <berrange>
Status:	CLOSED NEXTRELEASE	QA Contact:
Severity:	medium	Docs Contact:
Priority:	unspecified
Version:	unspecified	CC:	berrange, gunbird1, jtomko, laine, libvirt-maint, tburke, xvaotr
Target Milestone:	---
Target Release:	---
Hardware:	x86_64
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2019-08-12 12:18:38 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description dualdm 2019-07-23 06:47:52 UTC

Description of problem: 

error: unsupported configuration: an interface connecting to network 'ovs-network' is requesting a vlan tag, but that is not supported for this type of network


Version-Release number of selected component (if applicable):
v5.5.0

How reproducible:


Steps to Reproduce:
1.create ovs-network with some portgroups
2.create VM connected to such portgroup on ovs-network
3.start domain

Actual results:
error: unsupported configuration: an interface connecting to network 'ovs-network' is requesting a vlan tag, but that is not supported for this type of network

Expected results:
domain start

Additional info:

Comment 1 fold_right 2019-07-31 18:08:18 UTC

The issue can be reproduced in git tag v5.5.0, but not in v5.4.0.
The problem seems to be related to changes in network/bridge_driver.c, in networkAllocatePort function.

Comment 2 Daniel Berrangé 2019-08-07 12:58:46 UTC

I'm investigating the regression....

Comment 3 Daniel Berrangé 2019-08-08 12:46:32 UTC

This patch should fix it https://www.redhat.com/archives/libvir-list/2019-August/msg00201.html

Comment 4 dualdm 2019-08-12 12:18:38 UTC

Yes, fixed!

Thanks.

Comment 5 Ján Tomko 2019-08-13 10:12:56 UTC

Actually, per https://bugzilla.redhat.com/page.cgi?id=fields.html#bug_status the UPSTREAM
state is for bugs that have been forwarded to an upstream tracker.

This is the upstreamest tracker of them all for libvirt.


The bug was fixed by:
commit 93c1d5fe7bb7a62ef884eb41b505b2809d1704b6
Author:     Daniel P. Berrangé <berrange>
CommitDate: 2019-08-08 14:16:22 +0100

    network: fix ability to use openvswitch with vlans
    
    Use the correct enum constant when validating vlan usage.
    This fixes a merge error in
    
      commit 6cb0ec48bd95c95489a987e05a88e8bcf1f9109c
      Author: Daniel P. Berrangé <berrange>
      Date:   Mon Sep 3 17:34:22 2018 +0100
    
        network: convert networkAllocateActualDevice to virNetworkPortDef
    
    Reviewed-by: Michal Privoznik <mprivozn>
    Signed-off-by: Daniel P. Berrangé <berrange>

git describe: v5.6.0-81-g93c1d5fe7b

which will be released in libvirt-5.7.0