Bug 1732311
| Summary: | Review Request: perl-Test-NiceDump - Get a nice and human readable dump of objects | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Jitka Plesnikova <jplesnik> |
| Component: | Package Review | Assignee: | Petr Pisar <ppisar> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | package-review, ppisar |
| Target Milestone: | --- | Flags: | ppisar:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | perl-Test-NiceDump-1.0.1-1.fc31 | Doc Type: | If docs needed, set a value |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2019-07-24 13:10:34 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 1731013 | ||
|
Description
Jitka Plesnikova
2019-07-23 07:12:17 UTC
Url and Source0 addresses are Ok.
Source0 archive (SHA-256: 122877276af68032eb6d7f899ff4ec91c9e21380198fba73839b2e04ecd4ba63) is original. Ok.
Summary is Ok.
Description verified from lib/Test/NiceDump.pm. Ok.
License verified from lib/Test/NiceDump.pm, Makefile.PL, README.md, and LICENSE. Ok.
No XS code, noarch BuildArch is Ok.
BuildRequires are Ok.
TODO: Unset AUTHOR_TESTING environment variable in %check section to make the build reproducible (t/author-pod-coverage.t:4).
All tests pass. Ok.
$ rpmlint perl-Test-NiceDump.spec ../SRPMS/perl-Test-NiceDump-1.0.1-1.fc31.src.rpm ../RPMS/noarch/perl-Test-NiceDump-1.0.1-1.fc31.noarch.rpm
2 packages and 1 specfiles checked; 0 errors, 0 warnings.
rpmlint is Ok.
$ rpm -q -lv -p ../RPMS/noarch/perl-Test-NiceDump-1.0.1-1.fc31.noarch.rpm
drwxr-xr-x 2 root root 0 Jul 23 14:26 /usr/share/doc/perl-Test-NiceDump
-rw-r--r-- 1 root root 298 Jul 17 16:53 /usr/share/doc/perl-Test-NiceDump/Changes
-rw-r--r-- 1 root root 955 Jul 17 16:53 /usr/share/doc/perl-Test-NiceDump/README.md
drwxr-xr-x 2 root root 0 Jul 23 14:26 /usr/share/licenses/perl-Test-NiceDump
-rw-r--r-- 1 root root 18424 Jul 17 16:53 /usr/share/licenses/perl-Test-NiceDump/LICENSE
-rw-r--r-- 1 root root 2641 Jul 23 14:26 /usr/share/man/man3/Test::NiceDump.3pm.gz
drwxr-xr-x 2 root root 0 Jul 23 14:26 /usr/share/perl5/vendor_perl/Test
-rw-r--r-- 1 root root 6033 Jul 17 16:53 /usr/share/perl5/vendor_perl/Test/NiceDump.pm
File layout and permissions are Ok.
$ rpm -q --requires -p ../RPMS/noarch/perl-Test-NiceDump-1.0.1-1.fc31.noarch.rpm | sort -f | uniq -c
1 perl(:MODULE_COMPAT_5.30.0)
1 perl(Data::Dump)
1 perl(Data::Dump::Filtered)
1 perl(Exporter)
1 perl(overload)
1 perl(Safe::Isa) >= 1.000010
1 perl(strict)
1 perl(Test::Builder)
1 perl(warnings)
1 rpmlib(CompressedFileNames) <= 3.0.4-1
1 rpmlib(FileDigests) <= 4.6.0-1
1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
1 rpmlib(PayloadIsZstd) <= 5.4.18-1
Binary requires are Ok.
$ rpm -q --provides -p ../RPMS/noarch/perl-Test-NiceDump-1.0.1-1.fc31.noarch.rpm | sort -f | uniq -c
1 perl(Test::NiceDump) = 1.0.1
1 perl-Test-NiceDump = 1.0.1-1.fc31
Binary provides are Ok.
$ resolvedeps rawhide ../RPMS/noarch/perl-Test-NiceDump-1.0.1-1.fc31.noarch.rpm
Binary dependencies are resolvable. Ok.
The package builds in F31 (https://koji.fedoraproject.org/koji/taskinfo?taskID=36444787). Ok.
The package is in line with Fedora and Perl packaging guide lines.
Please consider fixing the 'TODO' item before building this package.
Resolution: Package APPROVED.
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-Test-NiceDump Thank you for the review and the repository. |