Bug 1732524

Summary:	repeated uninstallation of ipa-client-samba crashes
Product:	[Fedora] Fedora	Reporter:	Sergey Orlov <sorlov>
Component:	freeipa	Assignee:	François Cami <fcami>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	30	CC:	abokovoy, contribs, fcami, frenaud, ipa-maint, jcholast, jhrozek, pvoborni, rcritten, ssorce, twoerner
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	freeipa-4.8.1-1.fc30	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:
Clones:	1732529 (view as bug list)		Environment:
Last Closed:	2019-08-24 01:02:49 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1732529

Description Sergey Orlov 2019-07-23 15:11:14 UTC

Description of problem:
When "ipa-client-samba --uninstall" is uninstalled twice, it crashes

Version-Release number of selected component (if applicable):
freeipa-client-samba-4.8.0-1.fc30.x86_64

How reproducible:
Always

Steps to Reproduce:
1. ipa-client-samba -U 
2. ipa-client-samba -U --uninstall
3. ipa-client-samba -U --uninstall

Actual results:
Traceback (most recent call last):
  File "/usr/sbin/ipa-client-samba", line 15, in <module>
    sys.exit(ipa_client_samba.run())
  File "/usr/lib/python3.7/site-packages/ipaclient/install/ipa_client_samba.py", line 524, in run
    uninstall(fstore, statestore, options)
  File "/usr/lib/python3.7/site-packages/ipaclient/install/ipa_client_samba.py", line 437, in uninstall
    fstore.restore_file(paths.SMB_CONF)
  File "/usr/lib/python3.7/site-packages/ipalib/install/sysrestore.py", line 201, in restore_file
    raise ValueError("No such file name in the index")
ValueError: No such file name in the index


Expected results:
Samba domain member is not configured yet

Additional info:

Comment 1 François Cami 2019-07-23 21:05:02 UTC

Upstream ticket:
https://pagure.io/freeipa/issue/8019

Comment 2 Florence Blanc-Renaud 2019-07-26 13:13:37 UTC

Fixed upstream
ipa-4-8:
https://pagure.io/freeipa/c/b9b98097a47f27b56500edc972c438597e6609b1
https://pagure.io/freeipa/c/256a6a879061d2b97c11e9cd97b2427579610fa1
https://pagure.io/freeipa/c/00ba2ae6681dafa92d3f00f2a4e11adaa477ea0e
https://pagure.io/freeipa/c/551cd68d0959b1ee761ead6338dc06c544c0c5da

master:
https://pagure.io/freeipa/c/68b85703d8ab2ede823d96e317dd106de27b108b
https://pagure.io/freeipa/c/5b65551b3107e46853afcc4901a60ea6e661a511
https://pagure.io/freeipa/c/ed6ee90c547cd27a3731f177dc9917176a714b49
https://pagure.io/freeipa/c/cd2cbaecfce6b7b607619b34503b62c8afbbe594

Comment 3 Fedora Update System 2019-08-14 16:18:10 UTC

FEDORA-2019-d95d1971b2 has been submitted as an update to Fedora 30. https://bodhi.fedoraproject.org/updates/FEDORA-2019-d95d1971b2

Comment 4 Fedora Update System 2019-08-16 19:50:28 UTC

freeipa-4.8.1-1.fc30 has been pushed to the Fedora 30 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-d95d1971b2

Comment 5 Fedora Update System 2019-08-24 01:02:49 UTC

freeipa-4.8.1-1.fc30 has been pushed to the Fedora 30 stable repository. If problems still persist, please make note of it in this bug report.