Bug 1732581

Summary:	OCM integration tests don't test the product
Product:	OpenShift Container Platform	Reporter:	David Eads <deads>
Component:	openshift-controller-manager	Assignee:	Gabe Montero <gmontero>
Status:	CLOSED CURRENTRELEASE	QA Contact:	wewang <wewang>
Severity:	high	Docs Contact:
Priority:	high
Version:	4.2.0	CC:	aos-bugs, mfojtik
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2019-07-30 15:40:38 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description David Eads 2019-07-23 19:22:30 UTC

Existing integration tests do not test valid configuration modes or mechanisms for the OCM.  They rely on modes of wiring that have not been valid since 3.11 and are now impossible to wire. The tests should either be unit tests checking the behavior of specific pieces or e2e tests checking wiring.  These are the final integration tests being snipped today:


  TestBuildDefaultAnnotations
  TestBuildDefaultEnvironment
  TestBuildDefaultGitHTTPProxy
  TestBuildDefaultGitHTTPSProxy
  TestBuildDefaultLabels
  TestBuildDefaultNodeSelectors
  TestBuildDeleteController
  TestBuildOverrideAnnotations
  TestBuildOverrideForcePull
  TestBuildOverrideForcePullCustomStrategy
  TestBuildOverrideLabels
  TestBuildOverrideNodeSelectors
  TestBuildOverrideTolerations

Comment 1 David Eads 2019-07-24 14:10:34 UTC

A handy link to the final state of test-integration: https://github.com/openshift/origin/tree/ac77c8a2e1f2b93131daca15d1fdbeb8832840e7/test/integration

Comment 2 Adam Kaplan 2019-07-30 15:07:14 UTC

Also being tracked in JIRA - https://jira.coreos.com/browse/DEVEXP-381

Comment 3 Gabe Montero 2019-07-30 15:40:38 UTC

Let's just use the JIRA to track.

That way, QE dose not get pulled in (as that Jira is no-qe)

FYI PR https://github.com/openshift/origin/pull/23497 is up and is awaiting approve/lgtm