Bug 1732702
Summary: | python-pytest-mock: FTBFS in Fedora rawhide | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Miro Hrončok <mhroncok> |
Component: | python-pytest-mock | Assignee: | Julien Enselme <jujens> |
Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | high | Docs Contact: | |
Priority: | unspecified | ||
Version: | rawhide | CC: | jujens |
Target Milestone: | --- | Keywords: | Reopened |
Target Release: | --- | ||
Hardware: | Unspecified | ||
OS: | Unspecified | ||
URL: | http://apps.fedoraproject.org/koschei/package/python-pytest-mock | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | If docs needed, set a value | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2019-08-02 17:21:39 UTC | Type: | Bug |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 1700317, 1686977, 1732841 |
Description
Miro Hrončok
2019-07-24 07:38:32 UTC
*** Bug 1694192 has been marked as a duplicate of this bug. *** I still get failures in python2 tests during the 3.8 build: https://copr-be.cloud.fedoraproject.org/results/@python/python3.8/fedora-rawhide-x86_64/00989389-python-pytest-mock/ No idea why it works in Koji. Will recheck. Koji: ============================= test session starts ============================== platform linux2 -- Python 2.7.16, pytest-4.4.1, py-1.8.0, pluggy-0.11.0 rootdir: /builddir/build/BUILD/pytest-mock-1.10.4, inifile: tox.ini plugins: mock-1.10.4 collected 50 items test_pytest_mock.py ............................x..x..............s... [100%] ... =============== 47 passed, 1 skipped, 2 xfailed in 1.56 seconds ================ Copr: ============================= test session starts ============================== platform linux2 -- Python 2.7.16, pytest-4.4.1, py-1.8.0, pluggy-0.11.0 rootdir: /builddir/build/BUILD/pytest-mock-1.10.4, inifile: tox.ini plugins: mock-1.10.4 collected 50 items test_pytest_mock.py ...................FFFFF....x..x..............sF.. [100%] ... ========== 6 failed, 41 passed, 1 skipped, 2 xfailed in 2.26 seconds =========== It seems that the Python 2 tests are calling "python" and that is Python 3.8, but the ifs for 3.8 fail there. Scratch that. It's probably more complicated than that. + py.test-3.8 test_pytest_mock.py ============================= test session starts ============================== platform linux -- Python 3.8.0b3, pytest-4.6.4, py-1.8.0, pluggy-0.12.0 rootdir: /builddir/build/BUILD/pytest-mock-1.10.4, inifile: tox.ini plugins: mock-1.10.4 collected 50 items test_pytest_mock.py .................................................. [100%] ========================== 50 passed in 1.71 seconds =========================== To clarify, Python 3.8 tests pass fine, it's the Python 2.7 tests that fail when Python 3.8 is around. It's mock. Your koji build had python2-mock 2.0.0-13.fc30, my Copr build has 3.0.5-2.fc31. The fix is at: https://github.com/pytest-dev/pytest-mock/commit/b3badafebedea3605c90eb22a68adff2885a8bb0 This should be fixed in https://koji.fedoraproject.org/koji/taskinfo?taskID=36741265 Thank you! |