Bug 1732830

Summary: Request - Shutdown Save
Product: [Fedora] Fedora EPEL Reporter: ssoto
Component: redisAssignee: Nathan Scott <nathans>
Status: NEW --- QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: epel7CC: fabian.deutsch, fpercoco, jal233, lberk, mgoodwin, nathans
Target Milestone: ---   
Target Release: ---   
Hardware: x86_64   
OS: Linux   
Fixed In Version: Doc Type: Enhancement
Doc Text:
Feature: Ability to set shutdown parameter shutdown | shutdown save | shutdown nosave Reason: ability to SAVE even if no save point is configured Result:
Story Points: ---
Clone Of: Environment:
Last Closed: Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:

Description ssoto 2019-07-24 13:11:21 UTC
Description of problem:

Currently the redis systemd unit file calls "/usr/libexec/redis-shutdown" to shutdown. at the end of the shell script redis-shutdown logs in to the redis cli and calls the shutdown command. Would like have the ability to pass an option of shutdown | shutdown save | shutdown nosave as mentioned here: https://redis.io/commands/shutdown. 

there are some of us out there that do not write out to a file after redis commits and when properly shutting down just want to make sure the database gets fully saved off

additionally on an rpm update it would be a big problem if redis restarts and the database has not been saved off first so being able to pass an option to redis-shutdown would be very helpful. 

unfortunately redis-shutdown per the spec file does not have a noreplace option for it so if a person manually edits the redis-shutdown script it will be replaced during an update. 

Version-Release number of selected component (if applicable):


How reproducible:

Steps to Reproduce:
1. Install redis
2. modify redis-shutdown to state shutdown save
3. reinstall redis
4. see spec file

Actual results:

Expected results:

possibly have redis-shutdown load in a properties files that can be config(noreplace) where we can specify shutdown | shutdown save | shutdown nosave

Additional info: