Bug 1733263

Summary: [hackathon] service reconfiguration looses updated values
Product: Red Hat CloudForms Management Engine Reporter: Cyril Coupel <ccoupel>
Component: AutomateAssignee: Lucy Fu <lufu>
Status: CLOSED WONTFIX QA Contact: Niyaz Akhtar Ansari <nansari>
Severity: high Docs Contact: Red Hat CloudForms Documentation <cloudforms-docs>
Priority: high    
Version: 5.10.7CC: bmidwood, dmetzger, gmccullo, hkataria, idhaoui, juwatts, lavenel, lufu, mkanoor, mpovolny, obarenbo, simaishi, tfitzger, wfitzger
Target Milestone: GAKeywords: ZStream
Target Release: cfme-futureFlags: simaishi: cfme-5.11.z+
Hardware: All   
OS: All   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2021-03-09 22:06:45 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: Bug
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: CFME Core Target Upstream Version:
Embargoed:
Attachments:
Description Flags
PARAM values not updating none

Description Cyril Coupel 2019-07-25 14:36:42 UTC 
Description of problem:
when reconfiguring a service for a second time, the dialog values displayed in the dialog are not updated with the previous values but still contains the provisionned values.

Version-Release number of selected component (if applicable):
5.10.7

How reproducible:
every times

Steps to Reproduce:
1. order a catalog item with input valus (for example, field PARAM with value PARAM1)
2. once the service provisionned, do a reconfigure with different values (for example, field PARAM with NEW_PARAM2)
3. once the service updated, do an other reconfigure (for example, field PARAM show PARAM1 value)

Actual results:
the dialog field show the creation time values (for example field PARAM should be PARAM1)

Expected results:
the dialog field must show the last updated values (for example field PARAM should be NEW_PARAM2)

Additional info:
Comment 2 Tina Fitzgerald 2019-08-15 14:50:29 UTC 
Hi Billy, 

Can you provide the reproducer ip?

Thanks,
Tina
Comment 3 William Fitzgerald 2019-08-15 15:06:55 UTC 
reproducer: 10.8.99.161 
Version 5.10.8.0.20190729222758_e725e22

Same results on 5.11.0.6 appliance, reproducer: 10.8.99.218
Comment 4 Lucy Fu 2019-08-15 21:14:06 UTC 
There is a :create_options section in options of the service which contains all the information used when creating the service.
Then there is an :update_options section which contains all the data used when updating the service.
The :update_options data should be displayed if it exists when reconfigure is called again for the service.

Forward the BZ to UI team.
Comment 5 CFME Bot 2019-08-20 22:00:52 UTC 
https://github.com/ManageIQ/manageiq/pull/19178
Comment 6 CFME Bot 2019-12-09 19:55:52 UTC 
New commit detected on ManageIQ/manageiq/master:

https://github.com/ManageIQ/manageiq/commit/df01de81f73bae17ca66b21ea2dee659d64d5265
commit df01de81f73bae17ca66b21ea2dee659d64d5265
Author:     Lucy Fu <lufu>
AuthorDate: Tue Aug 20 17:48:23 2019 -0400
Commit:     Lucy Fu <lufu>
CommitDate: Tue Aug 20 17:48:23 2019 -0400

    Update service dialog options when reconfigure finishes well.

    Save the reconfigure dialog options into service.options[:dialog] if it finishes successfully.

    https://bugzilla.redhat.com/show_bug.cgi?id=1733263

 app/models/service_reconfigure_task.rb | 3 +
 spec/models/service_reconfigure_task_spec.rb | 14 +
 2 files changed, 17 insertions(+)
Comment 7 CFME Bot 2021-01-18 20:40:18 UTC 
New commit detected on ManageIQ/manageiq/ivanchuk:

https://github.com/ManageIQ/manageiq/commit/caa005c684c2b350ac35c3f67787d9b871adf4fe
commit caa005c684c2b350ac35c3f67787d9b871adf4fe
Author:     Greg McCullough <gmccullo>
AuthorDate: Mon Dec  9 19:55:18 2019 +0000
Commit:     Satoe Imaishi <simaishi>
CommitDate: Mon Jan 18 20:38:24 2021 +0000

    Merge pull request #19178 from lfu/reconfigure_update_dialog_options_1733263

    Update service dialog options when reconfigure finishes well.

    (cherry picked from commit 00e293496263e0e2e27edcca25b4a8dd413acefe)

    https://bugzilla.redhat.com/show_bug.cgi?id=1733263

 app/models/service_reconfigure_task.rb | 3 +
 spec/models/service_reconfigure_task_spec.rb | 14 +
 2 files changed, 17 insertions(+)
Comment 10 Niyaz Akhtar Ansari 2021-03-09 07:26:15 UTC 
Created attachment 1761931 [details]
PARAM values not updating