Bug 1733748

Summary: Remove cinder credentials from Cinder python help
Product: Red Hat OpenStack Reporter: Tzach Shefi <tshefi>
Component: python-cinderclientAssignee: Eric Harney <eharney>
Status: CLOSED DEFERRED QA Contact: Tzach Shefi <tshefi>
Severity: low Docs Contact: Chuck Copello <ccopello>
Priority: low    
Version: 15.0 (Stein)CC: abishop, eharney, jruzicka
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2019-07-30 02:15:34 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:

Description Tzach Shefi 2019-07-28 10:56:12 UTC
Description of problem: Cinder --help still lists cinder credentials as a valid command. As this command has already been deprecated we should cleanup cinder client's --help as well.  

$ cinder credentials
/usr/lib/python3.6/site-packages/cinderclient/v2/shell.py:940: UserWarning: ``cinder credentials`` is deprecated, use ``openstack token issue`` indead.
  "``cinder credentials`` is deprecated, use ``openstack token issue`` "


Version-Release number of selected component (if applicable):
puppet-cinder-14.4.1-0.20190420083336.1cf0604.el8ost.noarch
python3-cinderclient-4.2.0-0.20190520060354.953243d.el8ost.noarch


How reproducible:
Every time

Steps to Reproduce:
1. Issue cinder --help see cinder credentials command.   

2. Try to issue a cinder credentials get above error. 

3.

Actual results:
Fail to run a deprecated command, which is fine.


Expected results:
Cinder help shouldn't list deprecated commands once they were removed. 

Additional info:

Comment 1 Alan Bishop 2019-07-30 02:15:34 UTC
The cinder community needs to decide on when the deprecated v2 API will be removed. Until then, this bz behavior may be annoying, but doesn't cause a problem.

Comment 2 Eric Harney 2019-07-31 16:13:00 UTC
FWIW, this is on the list for the next major version bump of cinderclient:

https://review.opendev.org/#/c/653841/