Bug 1733862
| Summary: | fedpkg clone fails in _add_git_excludes() method | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Pavel Raiskup <praiskup> |
| Component: | rpkg | Assignee: | cqi |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | 30 | CC: | cqi, dennis, fweimer, jkeating, lsedlar, onosek, s |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | rpkg-1.59-1.fc31 rpkg-1.59-1.fc30 rpkg-1.59-1.fc29 rpkg-1.59-1.el6 rpkg-1.59-1.el7 | Doc Type: | If docs needed, set a value |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2019-09-21 00:01:59 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
Well, the clone seems to be finished (from what I can tell, enough for me), but the exit status is non-zero -> so tools working with fedpkg think that there's some problem (e.g. tito). That's weird. On my (docker) Fedora30 it works. fedpkg --verbose clone rpkg Cloning ssh://onosek.org/rpms/rpkg Running: git clone ssh://onosek.org/rpms/rpkg --origin origin Cloning into 'rpkg'... remote: Counting objects: 584, done. remote: Compressing objects: 100% (353/353), done. remote: Total 584 (delta 227), reused 583 (delta 227) Receiving objects: 100% (584/584), 158.35 KiB | 105.00 KiB/s, done. Resolving deltas: 100% (227/227), done. Git-excludes patterns were added into /home/onosek/rpkg/.git/info/exclude Could you, please, tell me what is a version of your tools? rpm -qa | grep "fedpkg\|rpkg\|git" will next command create 'exclude' file? git clone ssh://praiskup.org/rpms/rpkg file rpkg/.git/info/exclude (In reply to Ondřej Nosek from comment #2) > That's weird. On my (docker) Fedora30 it works. I did not try this in container. > Could you, please, tell me what is a version of your tools? > rpm -qa | grep "fedpkg\|rpkg\|git" $ rpm -q fedpkg python3-rpkg rpkg git fedpkg-1.37-4.fc30.noarch python3-rpkg-1.58-5.fc30.noarch rpkg-2.7-1.fc30.noarch git-2.21.0-1.fc30.x86_64 > will next command create 'exclude' file? > git clone ssh://praiskup.org/rpms/rpkg > file rpkg/.git/info/exclude $ git clone ssh://praiskup.org/rpms/rpkg Cloning into 'rpkg'... remote: Counting objects: 584, done. remote: Compressing objects: 100% (353/353), done. remote: Total 584 (delta 227), reused 583 (delta 227) Receiving objects: 100% (584/584), 158.35 KiB | 491.00 KiB/s, done. Resolving deltas: 100% (227/227), done. $ file rpkg/.git/info/exclude rpkg/.git/info/exclude: cannot open `rpkg/.git/info/exclude' (No such file or directory) Proposed fix: https://pagure.io/rpkg/pull-request/460 FEDORA-2019-28abfcf4b2 has been submitted as an update to Fedora 29. https://bodhi.fedoraproject.org/updates/FEDORA-2019-28abfcf4b2 FEDORA-2019-46aa409f08 has been submitted as an update to Fedora 30. https://bodhi.fedoraproject.org/updates/FEDORA-2019-46aa409f08 FEDORA-2019-609226dd65 has been submitted as an update to Fedora 31. https://bodhi.fedoraproject.org/updates/FEDORA-2019-609226dd65 FEDORA-EPEL-2019-4eb904f9c5 has been submitted as an update to Fedora EPEL 6. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2019-4eb904f9c5 FEDORA-EPEL-2019-d5733202f4 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2019-d5733202f4 rpkg-1.59-1.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2019-d5733202f4 rpkg-1.59-1.fc29 has been pushed to the Fedora 29 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-28abfcf4b2 rpkg-1.59-1.el6 has been pushed to the Fedora EPEL 6 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2019-4eb904f9c5 rpkg-1.59-1.fc30 has been pushed to the Fedora 30 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-46aa409f08 rpkg-1.59-1.fc31 has been pushed to the Fedora 31 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-609226dd65 rpkg-1.59-1.fc31 has been pushed to the Fedora 31 stable repository. If problems still persist, please make note of it in this bug report. rpkg-1.59-1.fc30 has been pushed to the Fedora 30 stable repository. If problems still persist, please make note of it in this bug report. rpkg-1.59-1.fc29 has been pushed to the Fedora 29 stable repository. If problems still persist, please make note of it in this bug report. rpkg-1.59-1.el6 has been pushed to the Fedora EPEL 6 stable repository. If problems still persist, please make note of it in this bug report. rpkg-1.59-1.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report. |
$ fedpkg --verbose clone rpkg Cloning ssh://praiskup.org/rpms/rpkg Running: git clone ssh://praiskup.org/rpms/rpkg --origin origin Cloning into 'rpkg'... remote: Counting objects: 581, done. remote: Compressing objects: 100% (574/574), done. remote: Total 581 (delta 224), reused 67 (delta 3) Receiving objects: 100% (581/581), 153.61 KiB | 479.00 KiB/s, done. Resolving deltas: 100% (224/224), done. Could not execute clone: [Errno 2] No such file or directory: '/tmp/rpkg/.git/info/exclude' Traceback (most recent call last): File "/usr/bin/fedpkg", line 11, in <module> load_entry_point('fedpkg==1.37', 'console_scripts', 'fedpkg')() File "/usr/lib/python3.7/site-packages/fedpkg/__main__.py", line 86, in main sys.exit(client.args.command()) File "/usr/lib/python3.7/site-packages/pyrpkg/cli.py", line 1864, in clone depth=self.args.depth) File "/usr/lib/python3.7/site-packages/pyrpkg/__init__.py", line 1550, in clone self._add_git_excludes(os.path.join(path, git_dir)) File "/usr/lib/python3.7/site-packages/pyrpkg/__init__.py", line 1675, in _add_git_excludes git_excludes.write() File "/usr/lib/python3.7/site-packages/pyrpkg/gitignore.py", line 83, in write with open(self.path, 'w') as f: FileNotFoundError: [Errno 2] No such file or directory: '/tmp/rpkg/.git/info/exclude'