Bug 1734496

Mass migration to Guangwu.

We can move this to modified whenever the flags allow, since our changes to the CLI for version 2.0.0 and 2.0.1 mean that the  message from the daemon that the CLI user previously saw will be replaced by a CLI-generated message that will contain the pool name along with other useful information.

Example: 
in RHEL 8.1, stratisd 1.0.4
- If a pool was failed and the list pool command as issued, the resulting output would look like this:
# stratis pool list
Execution failure caused by:
no total physical size computed for pool with uuid 9fcf7362-3f2a-4246-b27d-02e7f606849c

in RHEL 8.2, stratisd 2.0.0
- If a pool was failed and the list pool command as issued, the resulting output will look like this:
# stratis pool list
Name                  Total Physical
p1         1 GiB / FAILURE / FAILURE
p2    1 GiB / 37.63 MiB / 986.37 MiB

Recreate:
1. install startisd and stratis-cli
2. enable stratisd in systemd
3. create p1 
4. mount the mdv for p1
5. destroy pool p1
6. list stratis pools
---------
commands:
1. yum -y install stratis-cli
2. systemctl enable stratisd;systemctl start stratisd
3. truncate -s 1g /root/stratis.trunc1;losetup  /dev/loop1 /root/stratis.trunc1
4. mount /dev/mapper/stratis-1-private-{pool_name}-flex-mdv /mnt
5. stratis pool destroy p1
6. stratis pool list

If we look at the original bz, that was not about the error when listing the pool or the blockdevs, but about the error displayed when trying to create a new pool with blockdevs that already belonged to an existing pool. In the next version, not yet released, which we plan to be stratis-cli 2.0.1, the error looks like this:


# PYTHONPATH=./src ./bin/stratis pool create test_pool /dev/sda
# PYTHONPATH=./src ./bin/stratis pool list
Name                 Total Physical
test_pool   512 EiB / 0 B / 512 EiB
# PYTHONPATH=./src ./bin/stratis pool create test_pool_duplicate /dev/sda
Execution failed:
It appears that you issued an unintended command: At least one of the provided devices is already owned by an existing pool's Data tier; device /dev/sda would be added to the Data tier but is already in use in the Data tier of pool test_pool

In the current version, 2.0.0, it would do what was shown in https://bugzilla.redhat.com/show_bug.cgi?id=1686852
instead.

The reason for this is that now the CLI does a pre-check before issuing a command to the daemon on the D-Bus,
and if the pre-check fails, it returns an appropriate error. Previously, it sent the message to the daemon,
resulting in a less helpful error message for the CLI user.

We take the same approach consistently across all operations, so the CLI user should see consistently helpful error messages more relevant to the commands they entered in all situations.

This was fully resolved in upstream PR: https://github.com/stratis-storage/stratis-cli/pull/442.

Hello

[root@storageqe-26 ~]# stratis pool list
Name                             Total Physical   Properties
test-pool   447.11 GiB / FAILURE / FAILURE      ~Ca, Cr
[root@storageqe-26 ~]# 
[root@storageqe-26 ~]# rpm -qa |grep stratis
stratisd-2.1.0-1.el8.x86_64
stratis-cli-2.1.0-5.el8.noarch

so move to verified

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (stratis-cli bug fix and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2020:4794