Bug 173552
| Summary: | Review Request: xfce4-sensors-plugin | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Christoph Wickert <christoph.wickert> |
| Component: | Package Review | Assignee: | Luya Tshimbalanga <luya_tfz> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | David Lawrence <dkl> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-extras-list, nonamedotc, wtogami |
| Target Milestone: | --- | Flags: | gwync:
fedora-cvs+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| URL: | http://xfce-goodies.berlios.de/ | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2006-01-22 20:57:47 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 163779 | ||
|
Description
Christoph Wickert
2005-11-18 01:57:29 UTC
I will review your xfce packages. The result will be displayed later as I will be busy during Pacific daytime. So far, you had two FC-ACCEPTED packages. But this one also lacked libxfcegui4-devel. - Add libxfcegui4-devel BuildReqs. - Fix %defattr. New SRPM: http://home.arcor.de/christoph.wickert/fedora/extras-review/SRPMS/xfce4-sensors-plugin-0.7.0-2.fc4.src.rpm Detailed review: + mock succesfully built the source package. No errors reported + rpmlint did not complain. No warning nor errors reported + package follow the PackageNameGuideline procedure: http://fedoraproject.org/wiki/PackageNamingGuidelines + tarball from source rpm matched source url listed on spec file. Both matched by md5sum and sha1sum + No error reported after install and removed package + License listed on SPEC file matches the source tarball : http://fedoraproject.org/wiki/PackagingGuidelines#Legal + SPEC file conform to PackagingGuideline http://fedoraproject.org/wiki/PackagingGuidelines Accordingly, this package is ready to be submitted on Fedora Extras so the status is set to FE-ACCEPT. Add "ExcludeArch: ppc" (there is no lm_sensors for power pc.) Builds fine now. CLOSED (In reply to comment #4) > Add "ExcludeArch: ppc" (there is no lm_sensors for power pc.) see bug #178680 Package Change Request ====================== Package Name: xfce4-sensors-plugin New Branches: epel7 Owners: cwickert InitialCC: nonamedotc Git done (by process-git-requests). |