Bug 1735742

Summary:	Review Request: perl-Test-More-UTF8 - Test::More enhanced for UTF-8
Product:	[Fedora] Fedora	Reporter:	Petr Pisar <ppisar>
Component:	Package Review	Assignee:	Robert-André Mauchin 🐧 <eclipseo>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	eclipseo, package-review
Target Milestone:	---	Flags:	eclipseo: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:	perl-Test-More-UTF8-0.05-1.fc31	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2019-08-02 13:58:32 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Petr Pisar 2019-08-01 11:35:38 UTC

Spec URL: https://ppisar.fedorapeople.org/perl-Test-More-UTF8/perl-Test-More-UTF8.spec
SRPM URL: https://ppisar.fedorapeople.org/perl-Test-More-UTF8/perl-Test-More-UTF8-0.05-1.fc31.src.rpm
Description:
This Perl module enhances Test::More so that it can print Unicode strings.

Fedora Account System Username: ppisar

Comment 1 Robert-André Mauchin 🐧 2019-08-01 20:33:45 UTC

URL and Source addresses are Ok.
Source archive (SHA-256: b9f1c4b36a97cdfefaa53ed1115dd38f4b483037775f6559ee1df14acfd1ce04) is original. Ok.
Summary verified from lib/Test/More/UTF8.pm. Ok.
Description verified from lib/Test/More/UTF8.pm. Ok.
License verified from lib/Test/More/UTF8.pm and README. Ok.
No XS code, noarch BuildArch is Ok.

$ rpmlint perl-Test-More-UTF8.spec review-perl-Test-More-UTF8/results/perl-Test-More-UTF8-0.05-1.fc31.noarch.rpm review-perl-Test-More-UTF8/results/perl-Test-More-UTF8-0.05-1.fc31.src.rpm 
2 packages and 1 specfiles checked; 0 errors, 0 warnings.

$ rpm -q -lv -p perl-Test-More-UTF8-0.05-1.fc31.noarch.rpm 
drwxr-xr-x    2 root    root                        0 Aug  1 22:20 /usr/share/doc/perl-Test-More-UTF8
-rw-r--r--    1 root    root                      298 Jun 24  2017 /usr/share/doc/perl-Test-More-UTF8/Changes
-rw-r--r--    1 root    root                     1170 Jun 24  2017 /usr/share/doc/perl-Test-More-UTF8/README
-rw-r--r--    1 root    root                     1661 Aug  1 22:20 /usr/share/man/man3/Test::More::UTF8.3pm.gz
drwxr-xr-x    2 root    root                        0 Aug  1 22:20 /usr/share/perl5/vendor_perl/Test
drwxr-xr-x    2 root    root                        0 Aug  1 22:20 /usr/share/perl5/vendor_perl/Test/More
-rw-r--r--    1 root    root                     1906 Jun 24  2017 /usr/share/perl5/vendor_perl/Test/More/UTF8.pm
File permissions and layout are Ok.

$ rpm -q --requires -p perl-Test-More-UTF8-0.05-1.fc31.noarch.rpm | sort -f | uniq -c
      1 perl(:MODULE_COMPAT_5.30.0)
      1 perl(Carp)
      1 perl(strict)
      1 perl(Test::More)
      1 perl(utf8)
      1 perl(warnings)
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsZstd) <= 5.4.18-1
Binary requires are Ok.

$ rpm -q --provides -p perl-Test-More-UTF8-0.05-1.fc31.noarch.rpm 
perl(Test::More::UTF8) = 0.05
perl-Test-More-UTF8 = 0.05-1.fc31
Binary provides are Ok.

Package builds in Koji (https://koji.fedoraproject.org/koji/taskinfo?taskID=36741431).
Ok


Resolution: Package approved.

Comment 2 Gwyn Ciesla 2019-08-02 13:30:35 UTC

(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-Test-More-UTF8

Comment 3 Petr Pisar 2019-08-02 13:58:32 UTC

Thank you for the review and the repository.