Bug 1736009
| Summary: | Review Request: golang-github-zmap-zlint - X.509 Certificate Linter based on CA/B Forum Baseline Requirements and RFC 5280 | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Robert-André Mauchin 🐧 <zebob.m> |
| Component: | Package Review | Assignee: | Hirotaka Wakabayashi <hiwkby> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | hiwkby, package-review |
| Target Milestone: | --- | Flags: | hiwkby:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2019-08-19 17:47:53 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 1736010 | ||
|
Description
Robert-André Mauchin 🐧
2019-08-01 14:00:09 UTC
A successful Koji scratch build https://koji.fedoraproject.org/koji/taskinfo?taskID=36994859 Hello Robert-André, I reviewed this package. This packages SHOULD contain manpages for zlint and zlint-gtld-update. Please see the https://docs.fedoraproject.org/en-US/packaging-guidelines/#_manpages ``` golang-github-zmap-zlint.x86_64: W: no-manual-page-for-binary zlint golang-github-zmap-zlint.x86_64: W: no-manual-page-for-binary zlint-gtld-update ``` Here are the results of rpmlint. ``` $ rpmlint ~/rpmbuild/SRPMS/golang-github-zmap-zlint-0-0.1.20190801git9971d62.fc31.src.rpm golang-github-zmap-zlint.src: W: spelling-error %description -l en_US linter -> liner, liter, inter 1 packages and 0 specfiles checked; 0 errors, 1 warnings. $ rpmlint /home/vagrant/rpmbuild/RPMS/noarch/golang-github-zmap-zlint-devel-0-0.1.20190801git9971d62.fc31.noarch.rpm golang-github-zmap-zlint-devel.noarch: W: spelling-error %description -l en_US linter -> liner, liter, inter golang-github-zmap-zlint-devel.noarch: W: hidden-file-or-dir /usr/share/gocode/src/github.com/zmap/zlint/.goipath 1 packages and 0 specfiles checked; 0 errors, 2 warnings. $ rpmlint /home/vagrant/rpmbuild/RPMS/x86_64/golang-github-zmap-zlint-debuginfo-0-0.1.20190801git9971d62.fc31.x86_64.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. $ rpmlint /home/vagrant/rpmbuild/RPMS/x86_64/golang-github-zmap-zlint-0-0.1.20190801git9971d62.fc31.x86_64.rpm golang-github-zmap-zlint.x86_64: W: spelling-error %description -l en_US linter -> liner, liter, inter golang-github-zmap-zlint.x86_64: W: no-manual-page-for-binary zlint golang-github-zmap-zlint.x86_64: W: no-manual-page-for-binary zlint-gtld-update 1 packages and 0 specfiles checked; 0 errors, 3 warnings. $ rpmlint /home/vagrant/rpmbuild/RPMS/x86_64/golang-github-zmap-zlint-debugsource-0-0.1.20190801git9971d62.fc31.x86_64.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. ``` Thanks in advance, Hirotaka Wakabayashi New Spec URL: https://eclipseo.fedorapeople.org/for-review/golang-github-zmap-zlint.spec New SRPM URL: https://eclipseo.fedorapeople.org/for-review/golang-github-zmap-zlint-0-0.1.20190801git9971d62.fc31.src.rpm I added the manpages. Hello Robert-André, Thanks for fixing the problem. This package meets the quality control requirements for Fedora. Here are logs for reference. 1. rpmlint ``` $ rpmlint ~/rpmbuild/SRPMS/golang-github-zmap-zlint-0-0.1.20190801git9971d62.fc31.src.rpm golang-github-zmap-zlint.src: W: spelling-error %description -l en_US linter -> liner, liter, inter 1 packages and 0 specfiles checked; 0 errors, 1 warnings. $ rpmlint ~/rpmbuild/RPMS/x86_64/golang-github-zmap-zlint-debugsource-0-0.1.20190801git9971d62.fc31.x86_64.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. $ rpmlint ~/rpmbuild/RPMS/x86_64/golang-github-zmap-zlint-0-0.1.20190801git9971d62.fc31.x86_64.rpm golang-github-zmap-zlint.x86_64: W: spelling-error %description -l en_US linter -> liner, liter, inter 1 packages and 0 specfiles checked; 0 errors, 1 warnings. $ rpmlint ~/rpmbuild/RPMS/x86_64/golang-github-zmap-zlint-debugsource-0-0.1.20190801git9971d62.fc31.x86_64.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. $ rpmlint ~/rpmbuild/RPMS/noarch/golang-github-zmap-zlint-devel-0-0.1.20190801git9971d62.fc31.noarch.rpm golang-github-zmap-zlint-devel.noarch: W: spelling-error %description -l en_US linter -> liner, liter, inter golang-github-zmap-zlint-devel.noarch: W: hidden-file-or-dir /usr/share/gocode/src/github.com/zmap/zlint/.goipath 1 packages and 0 specfiles checked; 0 errors, 2 warnings. ``` 2. koji(success) http://koji.fedoraproject.org/koji/taskinfo?taskID=37036868 Best Regards, Hirotaka Wakabayashi (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-zmap-zlint |