Bug 1736067

Summary: libzypp: FTBFS in Fedora rawhide/f31: libzypp-17.12.0/zypp/target/rpm/RpmDb.cc:1562:22: error: 'VERIFY_DIGEST' was not declared in this scope
Product: [Fedora] Fedora Reporter: Fedora Release Engineering <releng>
Component: libzyppAssignee: Neal Gompa <ngompa13>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 31CC: besser82, ngompa13, ppisar
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: libzypp-17.14.0-1.fc31 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2019-09-14 00:06:24 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1700317, 1732841, 1737004, 1742317    
Attachments:
Description Flags
build.log
none
root.log
none
state.log none

Description Fedora Release Engineering 2019-08-01 14:36:25 UTC 
libzypp failed to build from source in Fedora rawhide/f31

https://koji.fedoraproject.org/koji/taskinfo?taskID=36635242


For details on the mass rebuild see:

https://fedoraproject.org/wiki/Fedora_31_Mass_Rebuild
Please fix libzypp at your earliest convenience and set the bug's status to
ASSIGNED when you start fixing it. If the bug remains in NEW state for 8 weeks,
libzypp will be orphaned. Before branching of Fedora 32,
libzypp will be retired, if it still fails to build.

For more details on the FTBFS policy, please visit:
https://fedoraproject.org/wiki/Fails_to_build_from_source
Comment 1 Fedora Release Engineering 2019-08-01 14:36:30 UTC 
Created attachment 1597598 [details]
build.log

file build.log too big, will only attach last 32768 bytes
Comment 2 Fedora Release Engineering 2019-08-01 14:36:32 UTC 
Created attachment 1597599 [details]
root.log

file root.log too big, will only attach last 32768 bytes
Comment 3 Fedora Release Engineering 2019-08-01 14:36:34 UTC 
Created attachment 1597600 [details]
state.log
Comment 4 Lukas Slebodnik 2019-08-08 11:51:37 UTC 
*** Bug 1722414 has been marked as a duplicate of this bug. ***
Comment 5 Ben Cotton 2019-08-13 16:54:38 UTC 
This bug appears to have been reported against 'rawhide' during the Fedora 31 development cycle.
Changing version to '31'.
Comment 6 Ben Cotton 2019-08-13 17:29:53 UTC 
This bug appears to have been reported against 'rawhide' during the Fedora 31 development cycle.
Changing version to 31.
Comment 7 Petr Pisar 2019-08-22 07:39:02 UTC 
From a build.log:

[ 31%] Building CXX object zypp/CMakeFiles/zypp.dir/target/rpm/RpmDb.cc.o
cd /builddir/build/BUILD/libzypp-17.12.0/armv7hl-redhat-linux-gnueabi/zypp && /usr/bin/c++  -DHAVE_PIPE2 -DHAVE_UDEV -DLOCALEDIR=\"/usr/share/locale\" -DTEXTDOMAIN=\"zypp\" -DVERSION=\"17.12.0\" -DWITH_LIBPROXY_SUPPORT -DZYPP_DLL -D_FILE_OFFSET_BITS=64 -Dzypp_EXPORTS -I/builddir/build/BUILD/libzypp-17.12.0 -I/builddir/build/BUILD/libzypp-17.12.0/armv7hl-redhat-linux-gnueabi -I/usr/include/rpm -I/usr/include/libxml2 -I/builddir/build/BUILD/libzypp-17.12.0/-D_FILE_OFFSET_BITS=64 -I/builddir/build/BUILD/libzypp-17.12.0/armv7hl-redhat-linux-gnueabi/zypp  -O2 -g -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -fexceptions -fstack-protector-strong -grecord-gcc-switches -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -march=armv7-a -mfpu=vfpv3-d16 -mtune=generic-armv7-a -mabi=aapcs-linux -mfloat-abi=hard -fno-strict-aliasing -fPIC -g -rdynamic -Wall -Wl,-as-needed -Wp,-D_GLIBCXX_ASSERTIONS -fvisibility-inlines-hidden -Woverloaded-virtual -Wnon-virtual-dtor -Werror=format-security -O2 -g -DNDEBUG -fPIC   -DZYPP_BASE_LOGGER_LOGGROUP=\"zypp\" -o CMakeFiles/zypp.dir/target/rpm/RpmDb.cc.o -c /builddir/build/BUILD/libzypp-17.12.0/zypp/target/rpm/RpmDb.cc
[...]
BUILDSTDERR: /builddir/build/BUILD/libzypp-17.12.0/zypp/target/rpm/RpmDb.cc:235:2: warning: #warning Check for obsolete memebers [-Wcpp]
BUILDSTDERR:   235 | #warning Check for obsolete memebers
BUILDSTDERR:       |  ^~~~~~~
BUILDSTDERR: /builddir/build/BUILD/libzypp-17.12.0/zypp/target/rpm/RpmDb.cc:411:2: warning: #warning CHECK: notify root about conversion backup. [-Wcpp]
BUILDSTDERR:   411 | #warning CHECK: notify root about conversion backup.
BUILDSTDERR:       |  ^~~~~~~
BUILDSTDERR: /builddir/build/BUILD/libzypp-17.12.0/zypp/target/rpm/RpmDb.cc:667:2: warning: #warning CHECK: compare vs existing v3 backup. notify root [-Wcpp]
BUILDSTDERR:   667 | #warning CHECK: compare vs existing v3 backup. notify root
BUILDSTDERR:       |  ^~~~~~~
BUILDSTDERR: /builddir/build/BUILD/libzypp-17.12.0/zypp/target/rpm/RpmDb.cc: In function 'zypp::target::rpm::RpmDb::CheckPackageResult zypp::target::rpm::{anonymous}::doCheckPackageSig(const zypp::filesystem::Pathname&, const zypp::filesystem::Pathname&, bool, zypp::target::rpm::RpmDb::CheckPackageDetail&)':
BUILDSTDERR: /builddir/build/BUILD/libzypp-17.12.0/zypp/target/rpm/RpmDb.cc:1562:22: error: 'VERIFY_DIGEST' was not declared in this scope; did you mean 'VERIFY_FILES'?
BUILDSTDERR:  1562 |     qva.qva_flags = (VERIFY_DIGEST|VERIFY_SIGNATURE);
BUILDSTDERR:       |                      ^~~~~~~~~~~~~
BUILDSTDERR:       |                      VERIFY_FILES
BUILDSTDERR: /builddir/build/BUILD/libzypp-17.12.0/zypp/target/rpm/RpmDb.cc:1562:36: error: 'VERIFY_SIGNATURE' was not declared in this scope
BUILDSTDERR:  1562 |     qva.qva_flags = (VERIFY_DIGEST|VERIFY_SIGNATURE);
BUILDSTDERR:       |                                    ^~~~~~~~~~~~~~~~
BUILDSTDERR: make[2]: *** [zypp/CMakeFiles/zypp.dir/build.make:1054: zypp/CMakeFiles/zypp.dir/target/rpm/RpmDb.cc.o] Error 1
BUILDSTDERR: make[2]: *** Waiting for unfinished jobs....
BUILDSTDERR: /builddir/build/BUILD/libzypp-17.12.0/zypp/target/rpm/RpmHeader.cc:395:2: warning: #warning CHECK IF FILE REQUIRES HANDLING IS OBSOLETE [-Wcpp]
BUILDSTDERR:   395 | #warning CHECK IF FILE REQUIRES HANDLING IS OBSOLETE
BUILDSTDERR:       |  ^~~~~~~

A difference between passing and failing build root is at <https://apps.fedoraproject.org/koschei/build/6582326>.

An upgrade of rpm-devel from 4.14.2.1-10.fc31 to 4.14.90-0.git14653.15... looks suspicious.
Comment 8 Neal Gompa 2019-08-25 21:29:34 UTC 
Failures still happening with a patch proposed upstream: https://github.com/openSUSE/libzypp/pull/172#issuecomment-524665361
Comment 9 Fedora Update System 2019-08-27 23:25:15 UTC 
FEDORA-2019-b3d7759646 has been submitted as an update to Fedora 31. https://bodhi.fedoraproject.org/updates/FEDORA-2019-b3d7759646
Comment 10 Fedora Update System 2019-08-29 21:01:26 UTC 
libzypp-17.14.0-1.fc31, zypper-1.14.29-1.fc31 has been pushed to the Fedora 31 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-b3d7759646
Comment 11 Fedora Update System 2019-09-14 00:06:24 UTC 
libzypp-17.14.0-1.fc31, zypper-1.14.29-1.fc31 has been pushed to the Fedora 31 stable repository. If problems still persist, please make note of it in this bug report.
Comment 12 Fedora Update System 2019-09-14 16:30:44 UTC 
libzypp-17.14.0-1.fc31, zypper-1.14.29-1.fc31 has been pushed to the Fedora 31 stable repository. If problems still persist, please make note of it in this bug report.