Bug 173670
| Summary: | Review Request: xfce4-wavelan-plugin | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Christoph Wickert <christoph.wickert> |
| Component: | Package Review | Assignee: | Ed Hill <ed> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | David Lawrence <dkl> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-extras-list, nonamedotc |
| Target Milestone: | --- | Flags: | gwync:
fedora-cvs+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| URL: | http://xfce-goodies.berlios.de/ | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2005-12-30 21:17:06 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 163779 | ||
|
Description
Christoph Wickert
2005-11-18 20:58:46 UTC
- Add libxfcegui4-devel BuildReqs. - Fix %defattr. New SRPM: http://home.arcor.de/christoph.wickert/fedora/extras-review/SRPMS/xfce4-wavelan-plugin-0.4.1-4.fc4.src.rpm Hi Christoph, heres a review: good: + name OK + source matches upstream + clean, simple, and legible specfile + license is correct (BSD) and included (good) + builds in mock on FC-4 + no rpmlint errors or warnings + dir ownership is OK + installs and works without segfaults on FC-4 This package is very simple and I don't see anything the matter with it so its APPROVED. Thanks for the review. Package builds fine on all branches & arches. Package Change Request ====================== Package Name: xfce4-wavelan-plugin New Branches: epel7 Owners: cwickert InitialCC: nonamedotc Git done (by process-git-requests). |