Bug 1736907

Summary: thonny: FTBFS in Fedora rawhide/f31
Product: [Fedora] Fedora Reporter: Fedora Release Engineering <releng>
Component: thonnyAssignee: Aivar Annamaa <aivar.annamaa>
Status: CLOSED WONTFIX QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 31CC: aivar.annamaa, mhroncok
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: thonny-3.2.1-1.fc32 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2020-06-12 09:56:10 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1700317, 1732841    
Attachments:
Description Flags
build.log
none
root.log
none
state.log none

Description Fedora Release Engineering 2019-08-02 09:36:40 UTC
thonny failed to build from source in Fedora rawhide/f31

https://koji.fedoraproject.org/koji/taskinfo?taskID=36637868


For details on the mass rebuild see:

https://fedoraproject.org/wiki/Fedora_31_Mass_Rebuild
Please fix thonny at your earliest convenience and set the bug's status to
ASSIGNED when you start fixing it. If the bug remains in NEW state for 8 weeks,
thonny will be orphaned. Before branching of Fedora 32,
thonny will be retired, if it still fails to build.

For more details on the FTBFS policy, please visit:
https://fedoraproject.org/wiki/Fails_to_build_from_source

Comment 1 Fedora Release Engineering 2019-08-02 09:36:43 UTC
Created attachment 1599669 [details]
build.log

file build.log too big, will only attach last 32768 bytes

Comment 2 Fedora Release Engineering 2019-08-02 09:36:46 UTC
Created attachment 1599670 [details]
root.log

file root.log too big, will only attach last 32768 bytes

Comment 3 Fedora Release Engineering 2019-08-02 09:36:47 UTC
Created attachment 1599671 [details]
state.log

Comment 4 Miro Hrončok 2019-08-02 09:54:09 UTC
This also blocks the Python 3.8 rebuild. The failure is:


___________________________________ test_all ___________________________________
    def test_all():
        for i, test in enumerate(TEST_GROUPS):
            print("Running test group %d: " % (i + 1))
>           _assert_returns_correct_indices(test[0], test[1], test[2])
thonny/test/plugins/test_name_highlighter.py:82: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
insert_pos_groups = (('1.4', '1.5', '1.7', '2.5'), ('4.6',), ('3.4',), ('5.7', '6.12'), ('4.10', '7.11'), ('10.2',), ...)
expected_indices = [{('1.4', '1.7'), ('2.4', '2.7')}, {('4.4', '4.7'), ('9.4', '9.7')}, set(), {('5.4', '5.7'), ('6.10', '6.13')}, {('4.8', '4.12'), ('7.10', '7.14')}, {('10.0', '10.4')}, ...]
input_str = 'def foo():\n    foo()\n    pass\ndef boo(narg):\n    foo = 2  # line 5\n    boo = foo + 4\n    print(narg + 2)\nfor i in range(5):\n    boo()\nnarg = 2  # line 10\ndef bar():\n    x + x\ndef blarg():\n    x = 2\n'
    def _assert_returns_correct_indices(insert_pos_groups, expected_indices, input_str):
        text_widget = tkinter.Text()
        text_widget.insert("end", input_str)
    
        nh = VariablesHighlighter(text_widget)
        for i, group in enumerate(insert_pos_groups):
            for insert_pos in group:
                text_widget.mark_set("insert", insert_pos)
    
                actual = nh.get_positions()
                expected = expected_indices[i]
    
>               assert actual == expected, (
                    "\nInsert position: %s"
                    "\nExpected: %s"
                    "\nGot: %s" % (insert_pos, expected, actual)
                )
E               AssertionError: 
E                 Insert position: 1.4
E                 Expected: {('1.4', '1.7'), ('2.4', '2.7')}
E                 Got: set()
E               assert set() == {('1.4', '1.7'), ('2.4', '2.7')}
E                 Extra items in the right set:
E                 ('1.4', '1.7')
E                 ('2.4', '2.7')
E                 Use -v to get the full diff
thonny/test/plugins/test_name_highlighter.py:97: AssertionError
----------------------------- Captured stdout call -----------------------------
Running test group 1:

Comment 5 Ben Cotton 2019-08-13 18:36:13 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 31 development cycle.
Changing version to 31.

Comment 6 Miro Hrončok 2019-08-14 22:24:45 UTC
The coordinated rebuild of Python 3.8 has started in the `f32-python` side tag.

If you figure out how to rebuild this package, please don't rebuild it in regular rawhide, but use the side tag instead:

    on branch master:
    $ fedpkg build --target=f32-python

To wait for a build to show up in the side tag, do:

    $ koji wait-repo f32-python --build=<nvr>

Where <nvr> is name-version-release of the source package, e.g. python-foo-1.1-2.fc32.

An updated mock config is posted at:
http://copr.fedorainfracloud.org/coprs/g/python/python3.8/

Note that it will take a while before the essential packages are rebuilt, so don't expect all your dependencies to be available right away.

Thanks. Let us know if you need up to date info, or if you have any questions.



PS this message is mass posted to all the bugs that block the PYTHON38 bug. If this is also a Fedora 31 FTBFS bug and you manage to fix it, you can do a f31 build as usual:

    on branch f31:
    $ fedpkg build

Comment 7 Miro Hrončok 2019-08-21 16:35:29 UTC
The f32-python side tag has been merged. In order to rebuild the package, do it in regular rawhide, but please wait until python3-3.8 is tagged:

  $ koji wait-repo f32-build --build python3-3.8.0~b3-3.fc32


If your built already started in f32-python, after it is finished, please tag it to rawhide with:

  $ koji tag-build f32-pending <nvr>

For example:

  $ koji tag-build f32-pending libreoffice-6.3.0.4-3.fc32

Thanks!

(This comment is mass posted to all bugzillas blocking the PYTHON38 tracking bug.)

Comment 8 Miro Hrončok 2019-08-21 17:29:28 UTC
(Python 3.8 has landed in the rawhide buildroot.)

Comment 9 Miro Hrončok 2019-09-09 10:31:24 UTC
This still fails in f31, but built in rawhide. Removing the PYTHON38 blocker.

___________________________________ test_all ___________________________________
    def test_all():
        if sys.version_info >= (3, 8):
            warnings.warn("Skipping name matcher tests in Python 3.8")
            return
    
        for i, test in enumerate(TEST_GROUPS):
            print("Running test group %d: " % (i + 1))
>           _assert_returns_correct_indices(test[0], test[1], test[2])
thonny/test/plugins/test_name_highlighter.py:88: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
insert_pos_groups = (('1.4', '1.5', '1.7', '2.5'), ('4.6',), ('3.4',), ('5.7', '6.12'), ('4.10', '7.11'), ('10.2',), ...)
expected_indices = [{('1.4', '1.7'), ('2.4', '2.7')}, {('4.4', '4.7'), ('9.4', '9.7')}, set(), {('5.4', '5.7'), ('6.10', '6.13')}, {('4.8', '4.12'), ('7.10', '7.14')}, {('10.0', '10.4')}, ...]
input_str = 'def foo():\n    foo()\n    pass\ndef boo(narg):\n    foo = 2  # line 5\n    boo = foo + 4\n    print(narg + 2)\nfor i in range(5):\n    boo()\nnarg = 2  # line 10\ndef bar():\n    x + x\ndef blarg():\n    x = 2\n'
    def _assert_returns_correct_indices(insert_pos_groups, expected_indices, input_str):
        text_widget = tkinter.Text()
        text_widget.insert("end", input_str)
    
        nh = VariablesHighlighter(text_widget)
        for i, group in enumerate(insert_pos_groups):
            for insert_pos in group:
                text_widget.mark_set("insert", insert_pos)
    
                actual = nh.get_positions()
                expected = expected_indices[i]
    
>               assert actual == expected, (
                    "\nInsert position: %s"
                    "\nExpected: %s"
                    "\nGot: %s" % (insert_pos, expected, actual)
                )
E               AssertionError: 
E                 Insert position: 1.4
E                 Expected: {('2.4', '2.7'), ('1.4', '1.7')}
E                 Got: set()
E               assert set() == {('1.4', '1.7'), ('2.4', '2.7')}
E                 Extra items in the right set:
E                 ('2.4', '2.7')
E                 ('1.4', '1.7')
E                 Use -v to get the full diff
thonny/test/plugins/test_name_highlighter.py:103: AssertionError
----------------------------- Captured stdout call -----------------------------
Running test group 1: 
====================== 1 failed, 5 passed in 0.45 seconds ======================

Comment 10 Miro Hrončok 2020-06-12 09:56:10 UTC
Let's keep Fedora 31 as is.