Bug 1737392

Summary:	oc new-build --help should not have some flags in the help text
Product:	OpenShift Container Platform	Reporter:	Saurabh Sadhale <ssadhale>
Component:	oc	Assignee:	Maciej Szulik <maszulik>
Status:	CLOSED ERRATA	QA Contact:	zhou ying <yinzhou>
Severity:	low	Docs Contact:
Priority:	low
Version:	3.11.0	CC:	aos-bugs, jokerman, maszulik, mfojtik, yinzhou
Target Milestone:	---	Flags:	maszulik: needinfo- maszulik: needinfo-
Target Release:	4.3.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:	Cause: oc new-build wasn't properly filtering flags displayed in help message. Consequence: The unnecessary flags were being printed when invoking oc new-build --help. Fix: Filter out flags that do not apply to oc new-build command. Result: The output of --help reflects its usage.	Story Points:	---
Clone Of:		Environment:
Last Closed:	2020-01-23 11:05:01 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Comment 1 Maciej Szulik 2019-08-06 13:42:03 UTC

I've fixed the sort-by flag in https://github.com/openshift/oc/pull/44 but the remaining two are coming from printer flags.
I'll need to have a one more look, though.

Comment 8 Maciej Szulik 2019-10-14 13:25:41 UTC

Checked against 4.3.0-0.ci-2019-10-14-031716 and it's working as expected.

Comment 10 zhou ying 2019-10-15 08:00:29 UTC

Confirmed with latest oc client, the issue has fixed:

oc version: 4.3.0-201910141917.git.1.7327846.el7

`oc new-build --help`  couldn't have the sort-by flag now.

Comment 17 errata-xmlrpc 2020-01-23 11:05:01 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2020:0062