Bug 1737449

Created attachment 1600635 [details]
Separate_Button_and_Button_Set

Description of problem:

We can create a Button Group and a button separately via the API but we can not associate the button with the button group. 
The API docs [1] only show how to create each one, nothing about associating them. The current behaviour is that the custom button is just placed in the 'unassigned' group.
We create the button set first, then in the custom button. we specify the ID of the button in the button order but this doesn't work. The UI show that the button set doesn't contain any buttons.

Version-Release number of selected component (if applicable):
5.10.5.1

How reproducible:
Always


Steps to Reproduce:

Step 1 : Create a button set using API

POST - https://10.74.131.62/api/custom_button_sets
BODY - 
	{
	  "name"        : "MyGroup1",
	  "description" : "MyGroup1",
	  "set_data"    : {
	    "button_icon"      : "ff ff-manageiq",
	    "button_color"     : "#4727ff",
	    "display"          : true,
	    "applies_to_class" : "Service"
	  }
	}


Step 2 : Create a button using API

POST - https://10.74.131.62/api/custom_buttons
BODY -

	{
	  "name"             : "MyButton",
	  "description"      : "MyButton",
	  "applies_to_class" : "Service",
	  "options"          : {
	    "button_icon"    : "ff ff-manageiq",
	    "button_color"   : "#4727ff",
	    "display"        : true
	  },
	  "resource_action"  : {
	    "ae_namespace"   : "SYSTEM",
	    "ae_class"       : "PROCESS"
	  },
	  "visibility"       : {
	    "roles"          : ["_ALL_"]
	  }
	}


Step 3 : Set the button_order for button_set using button ID (Because we want to assign button to button_set), Under RESPONSE the button_order has been properly assigned.

POST - https://10.74.131.62/api/custom_button_sets/1000000000032
BODY - 

	{
	  "action" : "edit",
	  "resource" : {
	    "set_data" : {
	      "button_order": [ "1000000000003" ],
	      "button_icon": "ff ff-manageiq",
	      "button_color": "#4727ff",
	      "display": true,
	      "applies_to_class": "Service"
	    }
	  }
	}

RESPONSE - 

	{
	    "href": "https://10.74.131.62/api/custom_button_sets/1000000000032",
	    "id": "1000000000032",
	    "set_data": {
	        "button_order": [
	            "1000000000003"
	        ],
	        "button_icon": "ff ff-manageiq",
	        "button_color": "#4727ff",
	        "display": true,
	        "applies_to_class": "Service"
	    },
	    "name": "MyGroup1",
	    "set_type": "CustomButtonSet",
	    "userid": null,
	    "group_id": null,
	    "description": "MyGroup1",
	    "created_on": "2019-08-05T11:06:45Z",
	    "updated_on": "2019-08-05T11:13:53Z",
	    "guid": "807ca229-cb87-454e-8947-4043fc34f4d1",
	    "read_only": null,
	    "mode": null,
	    "owner_type": null,
	    "owner_id": null
	}



Step 4 - Verify the button set

GET - https://10.74.131.62/api/custom_button_sets/1000000000032

RESPONSE - 
	{
	    "href": "https://10.74.131.62/api/custom_button_sets/1000000000032",
	    "id": "1000000000032",
	    "name": "MyGroup1",
	    "description": "MyGroup1",
	    "set_type": "CustomButtonSet",
	    "created_on": "2019-08-05T11:06:45Z",
	    "updated_on": "2019-08-05T11:13:53Z",
	    "guid": "807ca229-cb87-454e-8947-4043fc34f4d1",
	    "read_only": null,
	    "set_data": {
	        "button_order": [
	            "1000000000003"
	        ],
	        "button_icon": "ff ff-manageiq",
	        "button_color": "#4727ff",
	        "display": true,
	        "applies_to_class": "Service"
	    },
	    "mode": null,
	    "owner_type": null,
	    "owner_id": null,
	    "userid": null,
	    "group_id": null,
	    "actions": [
	        {
	            "name": "edit",
	            "method": "post",
	            "href": "https://10.74.131.62/api/custom_button_sets/1000000000032"
	        },
	        {
	            "name": "edit",
	            "method": "patch",
	            "href": "https://10.74.131.62/api/custom_button_sets/1000000000032"
	        },
	        {
	            "name": "edit",
	            "method": "put",
	            "href": "https://10.74.131.62/api/custom_button_sets/1000000000032"
	        },
	        {
	            "name": "delete",
	            "method": "post",
	            "href": "https://10.74.131.62/api/custom_button_sets/1000000000032"
	        },
	        {
	            "name": "delete",
	            "method": "delete",
	            "href": "https://10.74.131.62/api/custom_button_sets/1000000000032"
	        }
	    ]
	}

Step 5 : The assignment of button and button set is not working with above API calls.


Actual results:
In UI, we still see the button and button sets are separate (Screenshot Attached).

Expected results:
Buttons can be assigned to Button Sets using REST API

Additional info:
[1] http://manageiq.org/docs/reference/latest/api/reference/custom_buttons