Bug 1737768

Summary: Review Request: perl-Unix-Groups-FFI - Interface to Unix group system calls
Product: [Fedora] Fedora Reporter: Petr Pisar <ppisar>
Component: Package ReviewAssignee: Jitka Plesnikova <jplesnik>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: jplesnik, package-review
Target Milestone: ---Flags: jplesnik: fedora-review+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: perl-Unix-Groups-FFI-0.002-1.fc31 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2019-08-07 09:00:02 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Petr Pisar 2019-08-06 08:01:10 UTC 
Spec URL: https://ppisar.fedorapeople.org/perl-Unix-Groups-FFI/perl-Unix-Groups-FFI.spec
SRPM URL: https://ppisar.fedorapeople.org/perl-Unix-Groups-FFI/perl-Unix-Groups-FFI-0.002-1.fc31.src.rpm
Description:
This Perl module provides an FFI interface to several system calls related to
Unix groups, including getgroups(2), setgroups(2), getgrouplist(3), and
initgroups(3).

Fedora Account System Username: ppisar
Comment 1 Jitka Plesnikova 2019-08-06 11:51:51 UTC 
Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed
BuildRequires are ok

$ rpm -qp --requires perl-Unix-Groups-FFI-0.002-1.fc31.noarch.rpm | sort | uniq -c | grep -v rpmlib
      1 perl(Carp)
      1 perl(constant)
      1 perl(Errno)
      1 perl(Exporter) >= 5.57
      1 perl(FFI::Platypus) >= 0.20
      1 perl(:MODULE_COMPAT_5.30.0)
      1 perl(strict)
      1 perl(warnings)
Binary requires are Ok.

$ rpm -qp --provides perl-Unix-Groups-FFI-0.002-1.fc31.noarch.rpm | sort | uniq -c
      1 perl(Unix::Groups::FFI) = 0.002
      1 perl-Unix-Groups-FFI = 0.002-1.fc31
Binary provides are Ok.

$ rpmlint ./perl-Unix-Groups-FFI*
perl-Unix-Groups-FFI.noarch: W: spelling-error %description -l en_US getgroups -> get groups, get-groups, regroups
perl-Unix-Groups-FFI.noarch: W: spelling-error %description -l en_US setgroups -> set groups, set-groups, regroups
perl-Unix-Groups-FFI.noarch: W: spelling-error %description -l en_US getgrouplist -> gerontologist
perl-Unix-Groups-FFI.noarch: W: spelling-error %description -l en_US initgroups -> newsgroups
perl-Unix-Groups-FFI.src: W: spelling-error %description -l en_US getgroups -> get groups, get-groups, regroups
perl-Unix-Groups-FFI.src: W: spelling-error %description -l en_US setgroups -> set groups, set-groups, regroups
perl-Unix-Groups-FFI.src: W: spelling-error %description -l en_US getgrouplist -> gerontologist
perl-Unix-Groups-FFI.src: W: spelling-error %description -l en_US initgroups -> newsgroups
2 packages and 1 specfiles checked; 0 errors, 8 warnings.
Rpmlint is ok

Resolution:
Approved
Comment 2 Gwyn Ciesla 2019-08-06 15:10:26 UTC 
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-Unix-Groups-FFI
Comment 3 Petr Pisar 2019-08-07 09:00:02 UTC 
Thank you for the review and the repository.