Bug 1737782

Summary: Logrotate for atop will stop working on 2020
Product: [Fedora] Fedora EPEL Reporter: Guillem Cuberes <guillem.cuberes>
Component: atopAssignee: Gwyn Ciesla <gwync>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: low Docs Contact:
Priority: unspecified    
Version: el6CC: andy, gwync
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: atop-1.27-3.el6 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2019-08-22 02:23:07 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Guillem Cuberes 2019-08-06 08:38:20 UTC
Description of problem:
Logrotate file /etc/logrotate.d/atop provided by package atop-1.27-2.el6 depends on a pattern of atop logfiles to be /var/log/atop/atop_201[0-9][0-9][0-9][0-9][0-9], both in logrotate definition and in the postrotate action to remove old logs. That will stop working on year 2020.

Version-Release number of selected component (if applicable):
atop-1.27-2.el6

How reproducible:
Will be reproducible on 2020 always that /etc/logrotate.d/atop is left as is provided by package after installing.

Steps to Reproduce:
1. Install atop from epel6 (yum install atop)
2. Check contents of /etc/logrotate.d/atop provided by package atop-1.27-2.el6 (cat /etc/logrotate.d/atop )

Actual results:
/var/log/atop/atop_201[0-9][0-9][0-9][0-9][0-9] {
    missingok
    daily
    nodateext
    rotate 1
    ifempty
    nocreate
    postrotate
      /usr/bin/find /var/log/atop/ -maxdepth 1 -mount -name atop_201\[0-9\]\[0-9\]\[0-9\]\[0-9\]\[0-9\]\* -mtime +40 -exec /bin/rm {} \;
    endscript
}


Expected results:
/var/log/atop/atop_[0-9][0-9][0-9][0-9][0-9][0-9][0-9][0-9] {
    missingok
    daily
    nodateext
    rotate 1
    ifempty
    nocreate
    postrotate
      /usr/bin/find /var/log/atop/ -maxdepth 1 -mount -name atop_\[0-9\]\[0-9\]\[0-9\]\[0-9\]\[0-9\]\[0-9\]\[0-9\]\[0-9\]\* -mtime +40 -exec /bin/rm {} \;
    endscript
}


Additional info:
The change seems to come from bug 1024759.
If changes are made, please consider also the bug 1425830

Comment 1 Fedora Update System 2019-08-06 15:06:52 UTC
FEDORA-EPEL-2019-9070cc2d90 has been submitted as an update to Fedora EPEL 6. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2019-9070cc2d90

Comment 2 Fedora Update System 2019-08-07 03:58:01 UTC
atop-1.27-3.el6 has been pushed to the Fedora EPEL 6 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2019-9070cc2d90

Comment 3 Fedora Update System 2019-08-22 02:23:07 UTC
atop-1.27-3.el6 has been pushed to the Fedora EPEL 6 stable repository. If problems still persist, please make note of it in this bug report.